Skip to content

Commit 6f52856

Browse files
committed
fix: checkbox to useIsomorphicLayoutEffect
1 parent 03f3427 commit 6f52856

File tree

5 files changed

+81
-39
lines changed

5 files changed

+81
-39
lines changed

.changeset/chilled-cats-smash.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@primer/react': patch
3+
---
4+
5+
Update Checkbox component to useIsomorphicLayoutEffect instead of useLayoutEffect to support SSR

docs/package-lock.json

Lines changed: 70 additions & 35 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Checkbox.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
import styled from 'styled-components'
22
import {useProvidedRefOrCreate} from './hooks'
3-
import React, {ChangeEventHandler, InputHTMLAttributes, ReactElement, useContext, useLayoutEffect} from 'react'
3+
import React, {ChangeEventHandler, InputHTMLAttributes, ReactElement, useContext} from 'react'
44
import sx, {SxProp} from './sx'
5+
import useLayoutEffect from './utils/useIsomorphicLayoutEffect'
56
import {FormValidationStatus} from './utils/types/FormValidationStatus'
67
import {CheckboxGroupContext} from './CheckboxGroup'
78
import getGlobalFocusStyles from './_getGlobalFocusStyles'

src/stories/Checkbox.stories.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
1-
import React, {useLayoutEffect, useRef, useState} from 'react'
1+
import React, {useRef, useState} from 'react'
22
import {Meta} from '@storybook/react'
33
import styled from 'styled-components'
44

55
import {BaseStyles, Box, Checkbox, CheckboxProps, Text, ThemeProvider} from '..'
6+
import useLayoutEffect from '../utils/useIsomorphicLayoutEffect'
67
import {action} from '@storybook/addon-actions'
78
import {get} from '../constants'
89

0 commit comments

Comments
 (0)