Skip to content

Commit 0ecc07f

Browse files
improve typing for figma code connect files (#5707)
1 parent 67e5872 commit 0ecc07f

File tree

6 files changed

+13
-17
lines changed

6 files changed

+13
-17
lines changed

packages/react/src/Banner/Banner.figma.tsx

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
2-
// @ts-nocheck
31
import React from 'react'
42
import {Banner} from '../../src/experimental/'
53
import figma from '@figma/code-connect'
@@ -31,7 +29,7 @@ const componentProps = {
3129
false: figma.textContent('Body'),
3230
}),
3331
dismissible: figma.boolean('Dismissible?', {
34-
true: '() => { /* implement dismiss functionality */ }',
32+
true: () => {},
3533
false: undefined,
3634
}),
3735
}

packages/react/src/BranchName/BranchName.figma.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
2-
// @ts-nocheck
31
import React from 'react'
42
import BranchName from './BranchName'
53
import figma from '@figma/code-connect'

packages/react/src/Button/Button.figma.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
2-
// @ts-nocheck
31
import {figma} from '@figma/code-connect'
42
import {Button} from '../../src'
53
import React from 'react'

packages/react/src/Button/IconButton.figma.tsx

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,18 @@
1-
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
2-
// @ts-nocheck
31
import {figma} from '@figma/code-connect'
42
import {IconButton} from '../../src'
3+
import type {VariantType} from './types'
54
import React from 'react'
65

76
figma.connect(
87
IconButton,
98
'https://www.figma.com/design/GCvY3Qv8czRgZgvl1dG6lp/Primer-Web?node-id=30468-5843&t=eGzObFz2btFEDDNj-4',
109
{
1110
props: {
12-
icon: figma.instance('icon'),
13-
variant: figma.enum('variant', {
11+
icon: figma.instance<React.FunctionComponent>('icon'),
12+
variant: figma.enum<VariantType>('variant', {
1413
primary: 'primary',
15-
secondary: 'secondary',
14+
secondary: 'default',
1615
danger: 'danger',
17-
outline: 'outline',
1816
invisible: 'invisible',
1917
}),
2018
size: figma.enum('size', {

packages/react/src/Overlay/Overlay.figma.tsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,5 +9,9 @@ figma.connect(Overlay, 'https://www.figma.com/design/GCvY3Qv8czRgZgvl1dG6lp/Prim
99
children: figma.children('*'),
1010
overflow: figma.boolean('overflow'),
1111
},
12-
example: ({children}) => <Overlay>{children}</Overlay>,
12+
example: ({children}) => (
13+
<Overlay onClickOutside={() => {}} onEscape={() => {}} returnFocusRef={}>
14+
{children}
15+
</Overlay>
16+
),
1317
})

packages/react/src/SegmentedControl/SegmentedControl.figma.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
2-
// @ts-nocheck
31
import React from 'react'
42
import {SegmentedControl} from './SegmentedControl'
53
import figma from '@figma/code-connect'
@@ -48,6 +46,8 @@ figma.connect(
4846
selected: figma.enum('state', {selected: true}),
4947
icon: figma.instance('icon').getProps<{name: string; fn: React.ReactElement}>(),
5048
},
51-
example: ({selected, icon}) => <SegmentedControl.IconButton selected={selected} icon={icon.fn} />,
49+
example: ({selected, icon}) => (
50+
<SegmentedControl.IconButton aria-label="Describe action" selected={selected} icon={icon.fn} />
51+
),
5252
},
5353
)

0 commit comments

Comments
 (0)