From 9e68db96780e9806b43b06f5a9ecbe355c667543 Mon Sep 17 00:00:00 2001 From: Cole Bemis Date: Thu, 17 Feb 2022 09:12:21 -0800 Subject: [PATCH 1/3] Always ignore size prop --- src/rules/no-system-props.js | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/rules/no-system-props.js b/src/rules/no-system-props.js index 84583e54..873b0db9 100644 --- a/src/rules/no-system-props.js +++ b/src/rules/no-system-props.js @@ -13,15 +13,12 @@ const utilityComponents = new Set(['Box', 'Text']) // Components for which we allow a set of prop names const excludedComponentProps = new Map([ ['AnchoredOverlay', new Set(['width', 'height'])], - ['Avatar', new Set(['size'])], ['Dialog', new Set(['width', 'height'])], ['ProgressBar', new Set(['bg'])], - ['Spinner', new Set(['size'])], - ['StyledOcticon', new Set(['size'])], ['PointerBox', new Set(['bg'])] ]) -const alwaysExcludedProps = new Set(['variant']) +const alwaysExcludedProps = new Set(['variant', 'size']) module.exports = { meta: { From a64413aef359e8f16ca088f1975c5e2411c5ffb3 Mon Sep 17 00:00:00 2001 From: Cole Bemis Date: Thu, 17 Feb 2022 09:16:23 -0800 Subject: [PATCH 2/3] Create tender-humans-rest.md --- .changeset/tender-humans-rest.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/tender-humans-rest.md diff --git a/.changeset/tender-humans-rest.md b/.changeset/tender-humans-rest.md new file mode 100644 index 00000000..3ea0c5f4 --- /dev/null +++ b/.changeset/tender-humans-rest.md @@ -0,0 +1,5 @@ +--- +"eslint-plugin-primer-react": patch +--- + +`no-system-props`: Always ignore `size` prop From d2e74952a209666339abfc355d3abf956e2e7280 Mon Sep 17 00:00:00 2001 From: Cole Bemis Date: Thu, 17 Feb 2022 09:18:44 -0800 Subject: [PATCH 3/3] Update no-system-props.test.js --- src/rules/__tests__/no-system-props.test.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/rules/__tests__/no-system-props.test.js b/src/rules/__tests__/no-system-props.test.js index d143c6a5..13dbee33 100644 --- a/src/rules/__tests__/no-system-props.test.js +++ b/src/rules/__tests__/no-system-props.test.js @@ -19,7 +19,8 @@ ruleTester.run('no-system-props', rule, { `import {Box} from '@primer/react'; `, `import {ProgressBar} from '@primer/react'; `, `import {Button} from '@primer/react';