From d3cd8e521d00a48601a15c131d2b9c57febd6839 Mon Sep 17 00:00:00 2001 From: Josh Black Date: Wed, 9 Oct 2024 15:17:33 -0500 Subject: [PATCH 1/2] feat: move ButtonBase to experimental --- src/rules/__tests__/no-wildcard-imports.test.js | 6 +++--- src/rules/no-wildcard-imports.js | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/rules/__tests__/no-wildcard-imports.test.js b/src/rules/__tests__/no-wildcard-imports.test.js index a6de13a3..8c730e25 100644 --- a/src/rules/__tests__/no-wildcard-imports.test.js +++ b/src/rules/__tests__/no-wildcard-imports.test.js @@ -169,8 +169,8 @@ import type {BetterSystemStyleObject} from '@primer/react/lib-esm/sx'`, { code: `import {ButtonBase} from '@primer/react/lib-esm/Button/ButtonBase'; import type {ButtonBaseProps} from '@primer/react/lib-esm/Button/ButtonBase'`, - output: `import {ButtonBase} from '@primer/react' -import {type ButtonBaseProps} from '@primer/react'`, + output: `import {ButtonBase} from '@primer/react/experimental' +import {type ButtonBaseProps} from '@primer/react/experimental'`, errors: [ { messageId: 'wildcardMigration', @@ -188,7 +188,7 @@ import {type ButtonBaseProps} from '@primer/react'`, }, { code: `import type {ButtonBaseProps} from '@primer/react/lib-esm/Button/types'`, - output: `import {type ButtonBaseProps} from '@primer/react'`, + output: `import {type ButtonBaseProps} from '@primer/react/experimental'`, errors: [ { messageId: 'wildcardMigration', diff --git a/src/rules/no-wildcard-imports.js b/src/rules/no-wildcard-imports.js index 36425594..c9c7eba4 100644 --- a/src/rules/no-wildcard-imports.js +++ b/src/rules/no-wildcard-imports.js @@ -10,11 +10,11 @@ const wildcardImports = new Map([ { type: 'type', name: 'ButtonBaseProps', - from: '@primer/react', + from: '@primer/react/experimental', }, { name: 'ButtonBase', - from: '@primer/react', + from: '@primer/react/experimental', }, ], ], @@ -24,7 +24,7 @@ const wildcardImports = new Map([ { type: 'type', name: 'ButtonBaseProps', - from: '@primer/react', + from: '@primer/react/experimental', }, ], ], From 8c32ddfe4b8ef0463afd02ed585ffc744de62183 Mon Sep 17 00:00:00 2001 From: Josh Black Date: Wed, 9 Oct 2024 15:18:05 -0500 Subject: [PATCH 2/2] chore: add changeset --- .changeset/heavy-rings-hammer.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/heavy-rings-hammer.md diff --git a/.changeset/heavy-rings-hammer.md b/.changeset/heavy-rings-hammer.md new file mode 100644 index 00000000..eade3f6f --- /dev/null +++ b/.changeset/heavy-rings-hammer.md @@ -0,0 +1,5 @@ +--- +'eslint-plugin-primer-react': patch +--- + +Update no-wildcard-imports rule to move ButtonBase to `@primer/react/experimental`