From 2588cb4ddcc71daf7e11802fa9a60d1f4b68d5a3 Mon Sep 17 00:00:00 2001 From: Katie Langerman <18661030+langermank@users.noreply.github.com> Date: Wed, 28 Aug 2024 17:24:32 +0000 Subject: [PATCH 1/3] add rule --- src/rules/no-system-props.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/rules/no-system-props.js b/src/rules/no-system-props.js index 1d3d21c4..83cb111b 100644 --- a/src/rules/no-system-props.js +++ b/src/rules/no-system-props.js @@ -46,6 +46,7 @@ const excludedComponentProps = new Map([ ['ProgressBar', new Set(['bg'])], ['PointerBox', new Set(['bg'])], ['Truncate', new Set(['maxWidth'])], + ['Stack', new Set(['padding', 'gap'])], ]) const alwaysExcludedProps = new Set(['variant', 'size']) From 7e363bb735ff83f8759a801455c614791aaf6e5a Mon Sep 17 00:00:00 2001 From: Katie Langerman <18661030+langermank@users.noreply.github.com> Date: Wed, 28 Aug 2024 10:25:36 -0700 Subject: [PATCH 2/3] Create nervous-coats-cross.md --- .changeset/nervous-coats-cross.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/nervous-coats-cross.md diff --git a/.changeset/nervous-coats-cross.md b/.changeset/nervous-coats-cross.md new file mode 100644 index 00000000..346709bb --- /dev/null +++ b/.changeset/nervous-coats-cross.md @@ -0,0 +1,5 @@ +--- +"eslint-plugin-primer-react": patch +--- + +Fix `Stack` system prop for padding and gap From 36f2ec4acc74985e3f016372272deea243127ef1 Mon Sep 17 00:00:00 2001 From: Siddharth Kshetrapal Date: Thu, 29 Aug 2024 10:44:47 +0200 Subject: [PATCH 3/3] Update .changeset/nervous-coats-cross.md --- .changeset/nervous-coats-cross.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/nervous-coats-cross.md b/.changeset/nervous-coats-cross.md index 346709bb..cd910dcf 100644 --- a/.changeset/nervous-coats-cross.md +++ b/.changeset/nervous-coats-cross.md @@ -2,4 +2,4 @@ "eslint-plugin-primer-react": patch --- -Fix `Stack` system prop for padding and gap +no-system-props: Add `padding` and `gap` as exceptions for `Stack`