update the tests and remove the space after title node is removed

Author: broccolinisoup

src/rules/__tests__/no-deprecated-props.test.js

@@ -64,32 +64,27 @@ ruleTester.run('no-deprecated-props', rule, {
   ],
   invalid: [
     {
-      code: `
-        import {ActionList} from '@primer/react';
-        <ActionList>
-            <ActionList.Group title="Group heading 1">
-                <ActionList.Item>Item</ActionList.Item>
-            </ActionList.Group>
-            <ActionList.Group title="Group heading 2">
-                <ActionList.Item>Item 2</ActionList.Item>
-            </ActionList.Group>
-        </ActionList>`,
-      output: `
-        import {ActionList} from '@primer/react';
-        <ActionList>
-            <ActionList.Group>
-                <ActionList.GroupHeading>Group heading 1</ActionList.GroupHeading>
-                <ActionList.Item>Item</ActionList.Item>
-            </ActionList.Group>
-            <ActionList.Group>
-                <ActionList.GroupHeading>Group heading 2</ActionList.GroupHeading>
-                <ActionList.Item>Item 2</ActionList.Item>
-            </ActionList.Group>
-        </ActionList>`,
+      code: `<ActionList.Group title="Group heading 1"></ActionList.Group>`,
+      output: `<ActionList.Group><ActionList.GroupHeading>Group heading 1</ActionList.GroupHeading></ActionList.Group>`,
       errors: [
         {
           messageId: 'titlePropDeprecated',
         },
+      ],
+    },
+    {
+      code: `<ActionList.Group title="Group heading 1" sx={{padding: 2}}></ActionList.Group>`,
+      output: `<ActionList.Group sx={{padding: 2}}><ActionList.GroupHeading>Group heading 1</ActionList.GroupHeading></ActionList.Group>`,
+      errors: [
+        {
+          messageId: 'titlePropDeprecated',
+        },
+      ],
+    },
+    {
+      code: `<ActionList.Group variant="filled" title="Group heading 1"></ActionList.Group>`,
+      output: `<ActionList.Group variant="filled"><ActionList.GroupHeading>Group heading 1</ActionList.GroupHeading></ActionList.Group>`,
+      errors: [
         {
           messageId: 'titlePropDeprecated',
         },

src/rules/no-deprecated-props.js

@@ -29,22 +29,20 @@ module.exports = {
           return
         }
         const title = getJSXOpeningElementAttribute(node, 'title')
+
         if (title !== undefined) {
-          console.log('hello', title.name.name, title.value.value)
           context.report({
             node,
             messageId: 'titlePropDeprecated',
             fix(fixer) {
               const groupTitle = title.value.value
-              // const sourceCode = context.sourceCode
-              // const start = title.range[0]
-              // const end = sourceCode.getTokenAfter(title).range[1]
+              const start = title.range[0]
+              const end = title.range[1]
               return [
-                // fixer.removeRange([start, end]),
-                fixer.remove(title),
+                fixer.removeRange([start - 1, end]), // remove the space before the title as well
                 fixer.insertTextAfterRange(
                   [node.range[1], node.range[1]],
-                  `\n<ActionList.GroupHeading>${groupTitle}</ActionList.GroupHeading>;`,
+                  `<ActionList.GroupHeading>${groupTitle}</ActionList.GroupHeading>`,
                 ),
               ]
             },