From 7c5bb8080f0aeb119bccbe21a80fbf9d3ecd8ed9 Mon Sep 17 00:00:00 2001
From: lowendavid <66423906+lowendavid@users.noreply.github.com>
Date: Tue, 16 Jun 2020 10:50:18 +0200
Subject: [PATCH 1/3] Adding userId to smartadserver.md
Added the userId to the documentation.
---
dev-docs/bidders/smartadserver.md | 29 +++++++++++++++--------------
1 file changed, 15 insertions(+), 14 deletions(-)
diff --git a/dev-docs/bidders/smartadserver.md b/dev-docs/bidders/smartadserver.md
index bd95585686..1873858df7 100644
--- a/dev-docs/bidders/smartadserver.md
+++ b/dev-docs/bidders/smartadserver.md
@@ -9,6 +9,7 @@ gdpr_supported: true
schain_supported: true
tcf2_supported: true
usp_supported: true
+eids_supported: true
---
### Note:
@@ -17,21 +18,21 @@ The Smart AdServer bidder adaptor requires setup and approval from the Smart AdS
### Bid params
{: .table .table-bordered .table-striped }
-| Name | Scope | Description | Example | Type |
+| Name | Scope | Description | Example | Type |
|------------|----------|----------------------------------------------------------------------------------------------------------------|----------------------------------------------------------------------|-----------|
-| `siteId` | required | The placement site ID | `1234` | `integer` |
-| `pageId` | required | The placement page ID | `1234` | `integer` |
-| `formatId` | required | The placement format ID | `1234` | `integer` |
-| `domain` | optional | The network domain (default see example) | `'http://prg.smartadserver.com', 'https://prg.smartadserver.com'` | `string` |
-| `target` | optional | The keyword targeting | `'sport=tennis'` | `string` |
-| `currency` | optional | Override the default currency code (ISO 4217) of the ad request. (Default: `'USD'`) | `'EUR'` | `string` |
-| `bidfloor` | optional | Bid floor for this placement in USD or in the currency specified by the `currency` parameter. (Default: `0.0`) | `0.42` | `float` |
-| `appName` | optional | Mobile application name | `'Smart AdServer Preview'` | `string` |
-| `buId` | optional | Mobile application bundle ID | `'com.smartadserver.android.dashboard'` | `string` |
-| `ckId` | optional | Unique Smart AdServer user ID | `1234567890123456789` | `integer` |
-| `video` | optional | Parameter object for instream video. See [video Object](#smartadserver-video-object) | `{}` | `object` |
-| `schain` | optional | Supply Chain | `'1.0,1!exchange1.com,1234,1,bid-request-1,publisher,publisher.com'` | `string` |
-
+| `siteId` | required | The placement site ID | `1234` | `integer` |
+| `pageId` | required | The placement page ID | `1234` | `integer` |
+| `formatId` | required | The placement format ID | `1234` | `integer` |
+| `domain` | optional | The network domain (default see example) | `'http://prg.smartadserver.com', 'https://prg.smartadserver.com'` | `string` |
+| `target` | optional | The keyword targeting | `'sport=tennis'` | `string` |
+| `currency` | optional | Override the default currency code (ISO 4217) of the ad request. (Default: `'USD'`) | `'EUR'` | `string` |
+| `bidfloor` | optional | Bid floor for this placement in USD or in the currency specified by the `currency` parameter. (Default: `0.0`) | `0.42` | `float` |
+| `appName` | optional | Mobile application name | `'Smart AdServer Preview'` | `string` |
+| `buId` | optional | Mobile application bundle ID | `'com.smartadserver.android.dashboard'` | `string` |
+| `ckId` | optional | Unique Smart AdServer user ID | `1234567890123456789` | `integer` |
+| `video` | optional | Parameter object for instream video. See [video Object](#smartadserver-video-object) | `{}` | `object` |
+| `schain` | optional | Supply Chain | `'1.0,1!exchange1.com,1234,1,bid-request-1,publisher,publisher.com'` | `string` |
+| `userId` | optional | The UserId Module | `{ britepoolId, criteo, digitrust, id5Id, identityLink, liveIntentId, netId, parrableId, pubCommonId, unifiedId }` | `object` |
From aff746ada041d12bcbf5a80162ef4fcb921cad9c Mon Sep 17 00:00:00 2001
From: lowendavid <66423906+lowendavid@users.noreply.github.com>
Date: Wed, 17 Jun 2020 08:18:57 +0200
Subject: [PATCH 2/3] Update dev-docs/bidders/smartadserver.md
this should be userIds rather than eids_supported
Co-authored-by: Scott
---
dev-docs/bidders/smartadserver.md | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dev-docs/bidders/smartadserver.md b/dev-docs/bidders/smartadserver.md
index 1873858df7..754176eef8 100644
--- a/dev-docs/bidders/smartadserver.md
+++ b/dev-docs/bidders/smartadserver.md
@@ -9,7 +9,7 @@ gdpr_supported: true
schain_supported: true
tcf2_supported: true
usp_supported: true
-eids_supported: true
+userIds: britepoolId, criteo, digitrust, id5Id, identityLink, liveIntentId, netId, parrableId, pubCommonId, unifiedId
---
### Note:
From dcc2edb5d53e8e9ed54726ce00ebae96f3389edd Mon Sep 17 00:00:00 2001
From: lowendavid <66423906+lowendavid@users.noreply.github.com>
Date: Wed, 17 Jun 2020 08:35:41 +0200
Subject: [PATCH 3/3] Update dev-docs/bidders/smartadserver.md
This should not be with the bidder paramters and therefore should be moved out.
Co-authored-by: Scott
---
dev-docs/bidders/smartadserver.md | 1 -
1 file changed, 1 deletion(-)
diff --git a/dev-docs/bidders/smartadserver.md b/dev-docs/bidders/smartadserver.md
index 754176eef8..c970ff92aa 100644
--- a/dev-docs/bidders/smartadserver.md
+++ b/dev-docs/bidders/smartadserver.md
@@ -32,7 +32,6 @@ The Smart AdServer bidder adaptor requires setup and approval from the Smart AdS
| `ckId` | optional | Unique Smart AdServer user ID | `1234567890123456789` | `integer` |
| `video` | optional | Parameter object for instream video. See [video Object](#smartadserver-video-object) | `{}` | `object` |
| `schain` | optional | Supply Chain | `'1.0,1!exchange1.com,1234,1,bid-request-1,publisher,publisher.com'` | `string` |
-| `userId` | optional | The UserId Module | `{ britepoolId, criteo, digitrust, id5Id, identityLink, liveIntentId, netId, parrableId, pubCommonId, unifiedId }` | `object` |