From 5b2d0f42c7ab155eda5fba14de3e23bbda84ce16 Mon Sep 17 00:00:00 2001 From: Jason Miller Date: Tue, 15 Nov 2022 18:59:36 -0500 Subject: [PATCH 1/4] Remove text VNode casting from #257 (now handled by preactjs/preact#3801) --- src/index.js | 9 --------- 1 file changed, 9 deletions(-) diff --git a/src/index.js b/src/index.js index 8332afaf..278d4d3e 100644 --- a/src/index.js +++ b/src/index.js @@ -145,15 +145,6 @@ function _renderToString(vnode, context, isSvgMode, selectValue, parent) { rendered = rendered + _renderToString(child, context, isSvgMode, selectValue, parent); - - if ( - typeof child === 'string' || - typeof child === 'number' || - typeof child === 'bigint' - ) { - // @ts-ignore manually constructing a Text vnode - vnode[i] = h(null, null, child); - } } return rendered; } From 50a66ec74d2523a40ace6bec3e85fce06d405859 Mon Sep 17 00:00:00 2001 From: Jason Miller Date: Tue, 15 Nov 2022 19:10:49 -0500 Subject: [PATCH 2/4] Create empty-fans-agree.md --- .changeset/empty-fans-agree.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/empty-fans-agree.md diff --git a/.changeset/empty-fans-agree.md b/.changeset/empty-fans-agree.md new file mode 100644 index 00000000..7ed7224b --- /dev/null +++ b/.changeset/empty-fans-agree.md @@ -0,0 +1,5 @@ +--- +"preact-render-to-string": patch +--- + +Remove text VNode casting From 009d0295734ab1dfe951923df376fb5f62073b02 Mon Sep 17 00:00:00 2001 From: jdecroock Date: Sat, 25 Feb 2023 09:27:04 +0100 Subject: [PATCH 3/4] update preact version --- package-lock.json | 14 +++++++------- package.json | 4 ++-- test/render.test.js | 2 +- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/package-lock.json b/package-lock.json index 5bb75f18..419b127a 100644 --- a/package-lock.json +++ b/package-lock.json @@ -26,7 +26,7 @@ "lint-staged": "^10.5.3", "microbundle": "^0.15.1", "mocha": "^8.2.1", - "preact": "^10.11.1", + "preact": "^10.12.0", "prettier": "^2.2.1", "sinon": "^9.2.2", "sinon-chai": "^3.5.0", @@ -10791,9 +10791,9 @@ } }, "node_modules/preact": { - "version": "10.11.1", - "resolved": "https://registry.npmjs.org/preact/-/preact-10.11.1.tgz", - "integrity": "sha512-1Wz5PCRm6Fg+6BTXWJHhX4wRK9MZbZBHuwBqfZlOdVm2NqPe8/rjYpufvYCwJSGb9layyzB2jTTXfpCTynLqFQ==", + "version": "10.13.0", + "resolved": "https://registry.npmjs.org/preact/-/preact-10.13.0.tgz", + "integrity": "sha512-ERdIdUpR6doqdaSIh80hvzebHB7O6JxycOhyzAeLEchqOq/4yueslQbfnPwXaNhAYacFTyCclhwkEbOumT0tHw==", "dev": true, "funding": { "type": "opencollective", @@ -22502,9 +22502,9 @@ "dev": true }, "preact": { - "version": "10.11.1", - "resolved": "https://registry.npmjs.org/preact/-/preact-10.11.1.tgz", - "integrity": "sha512-1Wz5PCRm6Fg+6BTXWJHhX4wRK9MZbZBHuwBqfZlOdVm2NqPe8/rjYpufvYCwJSGb9layyzB2jTTXfpCTynLqFQ==", + "version": "10.13.0", + "resolved": "https://registry.npmjs.org/preact/-/preact-10.13.0.tgz", + "integrity": "sha512-ERdIdUpR6doqdaSIh80hvzebHB7O6JxycOhyzAeLEchqOq/4yueslQbfnPwXaNhAYacFTyCclhwkEbOumT0tHw==", "dev": true }, "preferred-pm": { diff --git a/package.json b/package.json index a4393301..80ac2720 100644 --- a/package.json +++ b/package.json @@ -32,7 +32,7 @@ "transpile:jsx": "microbundle src/jsx.js -o dist/jsx.js --target web --external preact && microbundle dist/jsx.js -o dist/jsx.js -f cjs --external preact", "copy-typescript-definition": "copyfiles -f src/*.d.ts dist", "test": "eslint src test && tsc && npm run test:mocha && npm run test:mocha:compat && npm run test:mocha:debug && npm run bench", - "test:mocha": "BABEL_ENV=test mocha -r @babel/register -r test/setup.js test/*.test.js", + "test:mocha": "cross-env BABEL_ENV=test mocha -r @babel/register -r test/setup.js test/*.test.js", "test:mocha:compat": "BABEL_ENV=test mocha -r @babel/register -r test/setup.js 'test/compat/index.test.js'", "test:mocha:debug": "BABEL_ENV=test mocha -r @babel/register -r test/setup.js 'test/debug/index.test.js'", "format": "prettier src/**/*.{d.ts,js} test/**/*.js --write", @@ -121,7 +121,7 @@ "lint-staged": "^10.5.3", "microbundle": "^0.15.1", "mocha": "^8.2.1", - "preact": "^10.11.1", + "preact": "^10.12.0", "prettier": "^2.2.1", "sinon": "^9.2.2", "sinon-chai": "^3.5.0", diff --git a/test/render.test.js b/test/render.test.js index 17391c3a..7ab0bcf8 100644 --- a/test/render.test.js +++ b/test/render.test.js @@ -1313,7 +1313,7 @@ describe('render', () => { ); } - expect(render()).to.equal('

P481

P476951

'); + expect(render()).to.equal('

P0-0

P0-1

'); }); }); }); From 00986eb6c32b52b7f0c3f2d43055084b4be704f9 Mon Sep 17 00:00:00 2001 From: jdecroock Date: Sat, 25 Feb 2023 09:28:03 +0100 Subject: [PATCH 4/4] remove cross-env --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 80ac2720..ffdf1984 100644 --- a/package.json +++ b/package.json @@ -32,7 +32,7 @@ "transpile:jsx": "microbundle src/jsx.js -o dist/jsx.js --target web --external preact && microbundle dist/jsx.js -o dist/jsx.js -f cjs --external preact", "copy-typescript-definition": "copyfiles -f src/*.d.ts dist", "test": "eslint src test && tsc && npm run test:mocha && npm run test:mocha:compat && npm run test:mocha:debug && npm run bench", - "test:mocha": "cross-env BABEL_ENV=test mocha -r @babel/register -r test/setup.js test/*.test.js", + "test:mocha": "BABEL_ENV=test mocha -r @babel/register -r test/setup.js test/*.test.js", "test:mocha:compat": "BABEL_ENV=test mocha -r @babel/register -r test/setup.js 'test/compat/index.test.js'", "test:mocha:debug": "BABEL_ENV=test mocha -r @babel/register -r test/setup.js 'test/debug/index.test.js'", "format": "prettier src/**/*.{d.ts,js} test/**/*.js --write",