From 356e0cfb31b317dbe4fbcc0a3309382cf6fa72fc Mon Sep 17 00:00:00 2001 From: Simon Binder Date: Mon, 28 Apr 2025 10:16:34 +0200 Subject: [PATCH 1/2] Add test ensuring delete returns changed rows --- packages/drift_sqlite_async/test/db_test.dart | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/packages/drift_sqlite_async/test/db_test.dart b/packages/drift_sqlite_async/test/db_test.dart index 39a5224..9e994c0 100644 --- a/packages/drift_sqlite_async/test/db_test.dart +++ b/packages/drift_sqlite_async/test/db_test.dart @@ -106,5 +106,16 @@ void main() { '[]' ])); }); + + test('delete', () async { + for (var i = 0; i < 10; i++) { + await dbu + .into(dbu.todoItems) + .insert(TodoItemsCompanion.insert(description: 'desc $i')); + } + + final deleted = await dbu.delete(dbu.todoItems).go(); + expect(deleted, 10); + }); }); } From b6946f21590b52214526b6c773a5b97f10e5e9a4 Mon Sep 17 00:00:00 2001 From: Simon Binder Date: Mon, 28 Apr 2025 16:26:06 +0200 Subject: [PATCH 2/2] Improve test name --- packages/drift_sqlite_async/test/db_test.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/drift_sqlite_async/test/db_test.dart b/packages/drift_sqlite_async/test/db_test.dart index 9e994c0..bda09df 100644 --- a/packages/drift_sqlite_async/test/db_test.dart +++ b/packages/drift_sqlite_async/test/db_test.dart @@ -107,7 +107,7 @@ void main() { ])); }); - test('delete', () async { + test('delete returns affected rows', () async { for (var i = 0; i < 10; i++) { await dbu .into(dbu.todoItems)