Skip to content

Commit 2596518

Browse files
committed
Fix lints, support dart2wasm
1 parent b20b3b3 commit 2596518

28 files changed

+173
-83
lines changed

melos.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ scripts:
4141

4242
test:
4343
description: Run tests in a specific package.
44-
run: dart test -p chrome,vm
44+
run: dart test -p chrome,vm --compilers dart2js,dart2wasm
4545
exec:
4646
concurrency: 1
4747
packageFilters:
File renamed without changes.
Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,2 @@
1-
library drift_sqlite_async;
2-
31
export './src/connection.dart';
42
export './src/executor.dart';

packages/drift_sqlite_async/lib/src/executor.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import 'dart:async';
22

33
import 'package:drift/backends.dart';
4-
import 'package:drift/src/runtime/query_builder/query_builder.dart';
4+
import 'package:drift/drift.dart';
55
import 'package:sqlite_async/sqlite3_common.dart';
66
import 'package:sqlite_async/sqlite_async.dart';
77

@@ -19,6 +19,7 @@ class _SqliteAsyncDelegate extends _SqliteAsyncQueryDelegate
1919

2020
_SqliteAsyncDelegate(this.db) : super(db, db.writeLock);
2121

22+
@override
2223
bool isInTransaction = false; // unused
2324

2425
@override

packages/drift_sqlite_async/pubspec.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,12 @@ environment:
1616
dependencies:
1717
drift: ">=2.19.0 <3.0.0"
1818
sqlite_async: ^0.11.0
19+
1920
dev_dependencies:
2021
build_runner: ^2.4.8
2122
drift_dev: ">=2.19.0 <3.0.0"
2223
glob: ^2.1.2
24+
lints: ^5.1.1
2325
sqlite3: ^2.4.0
2426
test: ^1.25.2
2527
test_api: ^0.7.0

packages/drift_sqlite_async/test/basic_test.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
// TODO
22
@TestOn('!browser')
3+
library;
4+
35
import 'dart:async';
46

57
import 'package:drift/drift.dart';

packages/drift_sqlite_async/test/db_test.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
// TODO
22
@TestOn('!browser')
3+
library;
4+
35
import 'package:drift/drift.dart';
46
import 'package:sqlite_async/sqlite_async.dart';
57
import 'package:test/test.dart';

packages/drift_sqlite_async/test/generated/database.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ class TodoDatabase extends _$TodoDatabase {
2121
}
2222

2323
class TodosMigrationDatabase extends TodoDatabase {
24-
TodosMigrationDatabase(SqliteConnection db) : super(db);
24+
TodosMigrationDatabase(super.db);
2525

2626
@override
2727
MigrationStrategy get migration {

packages/drift_sqlite_async/test/migration_test.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
@TestOn('!browser')
2+
library;
3+
24
import 'package:sqlite_async/sqlite_async.dart';
35
import 'package:test/test.dart';
46

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
include: package:lints/recommended.yaml

0 commit comments

Comments
 (0)