Skip to content

Commit f58cdb7

Browse files
committed
Add comments on waitForAsyncAttributes.
1 parent f214e26 commit f58cdb7

File tree

1 file changed

+2
-0
lines changed
  • packages/service-core/src/metrics/open-telemetry

1 file changed

+2
-0
lines changed

packages/service-core/src/metrics/open-telemetry/util.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,8 @@ export function createOpenTelemetryMetricsFactory(context: ServiceContext): Metr
6262
['instance_id']: instanceIdPromise
6363
});
6464

65+
// This triggers OpenTelemetry to resolve the async attributes (instanceIdPromise).
66+
// This will never reject, and we don't specifically need to wait for it.
6567
resource.waitForAsyncAttributes?.();
6668

6769
const meterProvider = new MeterProvider({

0 commit comments

Comments
 (0)