fix: CRUD Upload Queue Monitoring #311
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
#254 Added monitoring of the
ps_crudCRUD upload operations.The monitoring relies on
ps_crudrows being consumed and removed by theBackendConnectoruploadDatamethod. An upload delay is added if the CRUD entry at the head of the queue has not been changed between calls touploadData.The

ps_crudtable containsidanddatacolumns.idShould be a unique incrementing integer while thedatacolumn contains JSON of the CRUD data change operation.The raw
ps_crudentry is parsed into aCrudEntryinstance which exposes the data above. The mapping in the parsing mapsps_crud:id=>CrudEntry.clientIdandps_crud:data:idtoCrudEntry.id.The previous implementation incorrectly assumed
CrudEntry.idwas theps_crud:idcolumn value. This causes the monitoring check to think CRUD operations have not been consumed if there are multipleps_crudoperations for the same row (with the same data id). This causes a delay in uploads if a single row has been mutated multiple times.This PR updates the CRUD monitoring to use the correct
idvalue. Unit tests are also added to ensure the delay functions as planned.