Skip to content

Commit 6a3a740

Browse files
committed
Remove jQuery from forms helper javascript as well
This is a trivial piece of javascript, definitely doesn't need jQuery
1 parent 4cb846d commit 6a3a740

File tree

1 file changed

+12
-20
lines changed

1 file changed

+12
-20
lines changed

media/js/forms.js

Lines changed: 12 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,30 +1,22 @@
1-
$(document).ready(function(){
2-
$('textarea.markdown-content').each(function(idx, e) {
1+
document.addEventListener('DOMContentLoaded', () => {
2+
document.querySelectorAll('textarea.markdown-content').forEach((e) => {
33
attach_markdown_preview(e.id, 0);
44
});
55

6-
$('input.toggle-checkbox').each(function(idx, e) {
7-
$(this).change(function(e) {
8-
update_form_toggles($(this));
6+
document.querySelectorAll('input.toggle-checkbox').forEach((e) => {
7+
e.addEventListener('change', (ev) => {
8+
update_form_toggles(ev.target);
99
});
10-
update_form_toggles($(e));
10+
update_form_toggles(e);
1111
});
12-
1312
});
1413

1514
function update_form_toggles(e) {
16-
var toggles = e.data('toggles').split(',');
17-
var invert = e.data('toggle-invert');
18-
var show = e.is(':checked');
19-
if (invert) {
20-
show = !show;
21-
}
22-
$.each(toggles, function(i, name) {
23-
var e = $('#id_' + name);
24-
if (show) {
25-
$(e).parents('div.form-group').show();
26-
} else {
27-
$(e).parents('div.form-group').hide();
28-
}
15+
const show = e.checked ^ (e.dataset.toggleInvert === 'true');
16+
console.log("checked: " + e.checked + ", toggle: " + (e.dataset.toggleInvert === 'true') + ", show: " + show);
17+
18+
e.dataset.toggles.split(',').forEach((t) => {
19+
console.log('set for ' + t + ' to ' + show);
20+
document.getElementById('id_' + t).closest('div.form-group').style.display = show ? '' : 'none';
2921
});
3022
}

0 commit comments

Comments
 (0)