Skip to content

Conversation

@wch
Copy link
Collaborator

@wch wch commented Apr 17, 2024

This should fix #582.

@wch wch requested a review from kgartland-rstudio April 17, 2024 15:37
@github-actions
Copy link

github-actions bot commented Apr 17, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
4733 3533 75% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
rsconnect/main.py 61% 🟢
TOTAL 61% 🟢

updated for commit: 2e606d3 by action🐍

@kgartland-rstudio
Copy link
Contributor

I'm still seeing the same behavior:

rsconnect version
1.23.1.dev97+g2460f7d

Before deploy:

> tree
.
└── test
    └── index.html

then run:
> rsconnect deploy html test/index.html -n dogfood

After deploy:

> tree
.
├── rsconnect-python
│   └── html-test.json
└── test
    └── index.html

In rsconnect-python 1.23.0, the rsconnect-python record is stored at ~/Library/Application Support/rsconnect-python/applications/.

@wch
Copy link
Collaborator Author

wch commented Apr 17, 2024

Shoot, sorry about that. I had only passed the path argument to one of the two code paths. Should be fixed now. Sorry I missed that -- I was a bit too hasty there.

Copy link
Contributor

@kgartland-rstudio kgartland-rstudio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@wch wch merged commit ec482fb into master Apr 17, 2024
@wch wch deleted the fix-deploy-html-path branch April 17, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

deploy html creates an rsconnect-python record in PWD

3 participants