Filter out pip freeze output starting w/ "[notice]"

[sagerb]

Intent

The std output executed from the command of pip freeze is used to generate a project's requirements.txt file. As part of pip's standard functionality, checks for new version availability are executed "intermittently". When new versions are detected, the std output line starts with [notice]. For example:

[notice] A new release of pip is available: 23.1.2 -> 23.3
[notice] To update, run: pip install --upgrade pip

Since every line from the std output that does not contain reconnect is written into requirements.txt, the scenario where an upgrade is detected will cause the generated requirements.txt file to be invalid.

Resolves #270

Type of Change

• Bug Fix
• New Feature
• Breaking Change

Approach

Added filter to suppress the std output lines, which start with the text [notice].

Refactored filtering to allow testability.

Added test for filtering std output which contains and doesn't contain a line starting with `[notice]'

Automated Tests

The new unit tests should cover validation.

Directions for Reviewers

It is challenging to force the pip upgrade notices to occur. The best approach for validation is probably continuous no-harm validation.

Checklist

• I have updated CHANGELOG.md to cover notable changes.
• I have updated all related GitHub issues to reflect their current state.

[mmarchetti]

The change looks good. We should also pass the --disable-pip-version-check version to pip whenever we run it non-interactively.

[sagerb]

The change looks good. We should also pass the --disable-pip-version-check version to pip whenever we run it non-interactively.

I wondered about that earlier when I was formulating my strategy. I'll go ahead and add it.

[github-actions]

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines	Covered	Coverage	Threshold	Status
4240	2784	66%	0%	🟢

New Files

No new covered files...

Modified Files

File	Coverage	Status
rsconnect/environment.py	82%	🟢
rsconnect/main.py	56%	🟢
TOTAL	69%	🟢

updated for commit: 4cfbdf5 by action🐍

[kgartland-rstudio]

I have since got a new computer and can no longer reproduce the original issue even with the same version of Python and Pip. Instead I tried to excerise pip in every way I could think of with an older version of pip (22.1.2) and the current version of pip (23.3).

Tested with various content types.

• write-manifest --force-generate
• deploy --force-generate
• deploy (without requirements.txt)
• deploy (with requirements.txt)