Adds 'flask' sub-command #499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
tdstein
changed the title
mmarchetti
reviewed
Oct 18, 2023
mmarchetti
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
Adds the sub-command
flasktodeployandwrite-manifest.In both instances,
flaskis syntactic sugar. The underlying implementation is a direct alias to the existingapisub-command.Type of Change
Approach
The
apiimplementation supports Flask APIs. Therefore, a newAppModeis not required.This change adds an optional description parameter to the functions that construct the click argument. If provided, the value is used instead of
AppType#desc.Automated Tests
Directions for Reviewers
Try running
rsconnect deploy flaskandrsconnect write-manifest flask.Checklist