Skip to content

Conversation

@mmarchetti
Copy link
Contributor

Description

Set up Snyk scanning in CI to check:

  • Dependencies of rsconnect-python
  • Static code check for the rsconnect/ source

Testing Notes / Validation Steps

Run CI. Verify that Snyk console shows vulnerabilities (only) from dependencies declared in setup.py and code in the the rsconnect/ directory.

Copy link
Collaborator

@aronatkins aronatkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to do anything to have the test requirements files ignored?

@mmarchetti
Copy link
Contributor Author

Do we need to do anything to have the test requirements files ignored?

No, since we're specifying --file, Snyk will not detect other "subprojects" such as docs/requirements.txt.

@mmarchetti
Copy link
Contributor Author

Will need to rebase this and resolve conflicts once #329 lands.

@mmarchetti mmarchetti merged commit 634ab66 into master Jan 5, 2023
@mmarchetti mmarchetti deleted the mm-snyk branch January 5, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants