show help instead of err for more commands #306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@edavidaja i don't have access to your private repo to test this. Can you bring this change over to our repo for testing? |
Contributor
|
@edavidaja disregard; i was able to get the fork afterall. |
kgartland-rstudio
approved these changes
Nov 29, 2022
Contributor
kgartland-rstudio
left a comment
kgartland-rstudio
left a comment
There was a problem hiding this comment.
Looks good. Missing commands now show help page where necessary.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
a few top level commands error rather than returning help when invoked without arguments; I've applied to the
no_args_is_helpoption to those commands.