Skip to content

Commit fadebac

Browse files
authored
Merge pull request #303 from rstudio/bcwu-update_write-manifest
fix write-manifest-notebook not using hide input
2 parents 0d367dd + e9032a5 commit fadebac

File tree

3 files changed

+14
-1
lines changed

3 files changed

+14
-1
lines changed

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,11 @@ All notable changes to this project will be documented in this file.
44
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
55
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
66

7+
## [1.12.1] - 2022-11-07
8+
9+
### Changed
10+
- Updated actions.py to reuse code in main, minus the CLI parts. As a result deploy_jupyter_notebook and deploy_by_manifest had their return signatures changed. They now return None.
11+
712
## [1.12.0] - 2022-10-26
813

914
### Added

rsconnect/bundle.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1255,6 +1255,14 @@ def write_notebook_manifest_json(
12551255
raise RSConnectException('Could not determine the app mode from "%s"; please specify one.' % extension)
12561256

12571257
manifest_data = make_source_manifest(app_mode, environment, file_name, None, image)
1258+
if hide_all_input or hide_tagged_input:
1259+
if "jupyter" not in manifest_data:
1260+
manifest_data["jupyter"] = dict()
1261+
if hide_all_input:
1262+
manifest_data["jupyter"]["hide_all_input"] = True
1263+
if hide_tagged_input:
1264+
manifest_data["jupyter"]["hide_tagged_input"] = True
1265+
12581266
manifest_add_file(manifest_data, file_name, directory)
12591267
manifest_add_buffer(manifest_data, environment.filename, environment.contents)
12601268

rsconnect/main.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1283,7 +1283,7 @@ def write_manifest():
12831283
is_flag=True,
12841284
help='Force generating "requirements.txt", even if it already exists.',
12851285
)
1286-
@click.option("--hide-all-input", help="Hide all input cells when rendering output")
1286+
@click.option("--hide-all-input", is_flag=True, default=None, help="Hide all input cells when rendering output")
12871287
@click.option("--hide-tagged-input", is_flag=True, default=None, help="Hide input code cells with the 'hide_input' tag")
12881288
@click.option("--verbose", "-v", "verbose", is_flag=True, help="Print detailed messages")
12891289
@click.option(

0 commit comments

Comments
 (0)