Skip to content

Commit 2134be8

Browse files
authored
Merge branch 'master' into consistent-help
2 parents 8681315 + 9284463 commit 2134be8

File tree

2 files changed

+16
-10
lines changed

2 files changed

+16
-10
lines changed

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.
44
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
55
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
66

7+
## [Unreleased]
8+
9+
### Changed
10+
11+
Update pip_freeze to use `pip freeze` since Connect filters for valid package paths in the backend and it no longer depends on the undocumented behavior of `pip list --format=freeze`. This reverts the change made in 1.5.2.
12+
713
## [1.12.1] - 2022-11-07
814

915
### Changed

rsconnect/environment.py

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -43,15 +43,15 @@
4343

4444

4545
def MakeEnvironment(
46-
conda=None, # type: Optional[str]
47-
contents="", # type: Optional[str]
48-
error=None, # type: Optional[str]
49-
filename="", # type: Optional[str]
50-
locale="", # type: Optional[str]
51-
package_manager="", # type: Optional[str]
52-
pip=None, # type: Optional[str]
53-
python=None, # type: Optional[str]
54-
source=None, # type: Optional[str]
46+
conda: Optional[str] = None,
47+
contents: Optional[str] = None,
48+
error: Optional[str] = None,
49+
filename: Optional[str] = None,
50+
locale: Optional[str] = None,
51+
package_manager: Optional[str] = None,
52+
pip: Optional[str] = None,
53+
python: Optional[str] = None,
54+
source: Optional[str] = None,
5555
):
5656
return Environment(conda, contents, error, filename, locale, package_manager, pip, python, source)
5757

@@ -218,7 +218,7 @@ def pip_freeze():
218218
"""
219219
try:
220220
proc = subprocess.Popen(
221-
[sys.executable, "-m", "pip", "list", "--format=freeze"],
221+
[sys.executable, "-m", "pip", "freeze"],
222222
stdout=subprocess.PIPE,
223223
stderr=subprocess.PIPE,
224224
universal_newlines=True,

0 commit comments

Comments
 (0)