Skip to content

Remove id from render_widget_base.auto_output_ui #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 18, 2024
Merged

Remove id from render_widget_base.auto_output_ui #130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96a333c
bump shiny requirement to 0.6.9005
schloerke Jan 18, 2024
a38f378
implement no id from auto_output_ui
schloerke Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ setup_requires =
install_requires =
ipywidgets>=7.6.5
jupyter_core
shiny>=0.6.1.9004
shiny>=0.6.1.9005
python-dateutil>=2.8.2
# Needed because of https://github.com/python/importlib_metadata/issues/411
importlib-metadata>=4.8.3,<5; python_version < "3.8"
Expand Down
7 changes: 4 additions & 3 deletions shinywidgets/_render_widget_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,13 @@
"""
T = TypeVar("T", bound=object)


class render_widget_base(Renderer[ValueT], Generic[ValueT, WidgetT]):
""" """

def auto_output_ui(self, id: str) -> Tag:
def auto_output_ui(self) -> Tag:
return output_widget(
id,
self.output_id,
width=self.width,
height=self.height,
fill=self.fill,
Expand Down Expand Up @@ -201,7 +202,7 @@ def set_layout_defaults(widget: Widget) -> Tuple[Widget, bool]:
warnings.warn(
"Consider using shiny.ui.layout_column_wrap() instead of alt.concat() "
"for multi-column layout (the latter doesn't support filling layout).",
stacklevel=2
stacklevel=2,
)
else:
UndefinedType = alt.utils.schemapi.UndefinedType # type: ignore
Expand Down