-
Notifications
You must be signed in to change notification settings - Fork 7
Open
Description
Given #119, register_widget() does not follow the Shiny rendering pattern.
Current (inside server body):
map = create_map(layout=ipywidgets.Layout(width="100%", height="100%"))
map_widget = register_widget("map", map)
map_widget # do stuffProposed:
map_val = create_map(layout=ipywidgets.Layout(width="100%", height="100%"))
@render_widget
def map():
return map_val
map.widget # do stuffWhile the Current approach is tighter and requires less lines, calling a register method doesn't tell me that it's going to be rendered to the UI.
With more render methods with full typing in the near future, I'd recommend that register_widget be deprecated in favor of the standard Shiny approach.
Metadata
Metadata
Assignees
Labels
No labels