From 80af87d47537fa5464e9ef25a8dea396a244f81b Mon Sep 17 00:00:00 2001 From: Winston Chang Date: Wed, 10 Jan 2024 15:19:49 -0600 Subject: [PATCH 1/2] Change page_sidebar() and page_navbar() to default to fillable=False --- shiny/ui/_page.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/shiny/ui/_page.py b/shiny/ui/_page.py index 008ac9b80..fcf34b878 100644 --- a/shiny/ui/_page.py +++ b/shiny/ui/_page.py @@ -44,7 +44,7 @@ def page_sidebar( sidebar: Sidebar, *args: TagChild | TagAttrs, title: Optional[str | Tag | TagList] = None, - fillable: bool = True, + fillable: bool = False, fillable_mobile: bool = False, window_title: str | MISSING_TYPE = MISSING, lang: Optional[str] = None, @@ -116,7 +116,7 @@ def page_navbar( sidebar: Optional[Sidebar] = None, # Only page_navbar gets enhanced treatement for `fillable` # If an `*args`'s `data-value` attr string is in `fillable`, then the component is fillable - fillable: bool | list[str] = True, + fillable: bool | list[str] = False, fillable_mobile: bool = False, gap: Optional[CssUnit] = None, padding: Optional[CssUnit | list[CssUnit]] = None, From ca6d6a679d8be4dc083b0991109724a16a79d00a Mon Sep 17 00:00:00 2001 From: Winston Chang Date: Wed, 10 Jan 2024 15:22:28 -0600 Subject: [PATCH 2/2] Update changelog --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7a96a2617..d1974b3ed 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [UNRELEASED] +### Breaking Changes + +* Closed #938: `page_sidebar()` and `page_navbar()` now use `fillable=False` by default. (#990) + ### Bug fixes * CLI command `shiny create`... (#965)