diff --git a/CHANGELOG.md b/CHANGELOG.md index d4939566b..79bb8d731 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [UNRELEASED] +### Breaking Changes + +* Closed #938: `page_sidebar()` and `page_navbar()` now use `fillable=False` by default. (#990) ### New features diff --git a/shiny/ui/_page.py b/shiny/ui/_page.py index 008ac9b80..fcf34b878 100644 --- a/shiny/ui/_page.py +++ b/shiny/ui/_page.py @@ -44,7 +44,7 @@ def page_sidebar( sidebar: Sidebar, *args: TagChild | TagAttrs, title: Optional[str | Tag | TagList] = None, - fillable: bool = True, + fillable: bool = False, fillable_mobile: bool = False, window_title: str | MISSING_TYPE = MISSING, lang: Optional[str] = None, @@ -116,7 +116,7 @@ def page_navbar( sidebar: Optional[Sidebar] = None, # Only page_navbar gets enhanced treatement for `fillable` # If an `*args`'s `data-value` attr string is in `fillable`, then the component is fillable - fillable: bool | list[str] = True, + fillable: bool | list[str] = False, fillable_mobile: bool = False, gap: Optional[CssUnit] = None, padding: Optional[CssUnit | list[CssUnit]] = None,