Make --app-path work with app file argument #598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Beware: I don't believe this is an area where we have great (any?) automated tests right now. |
Collaborator
|
Works as expected on my machine. Should we make a followup about adding tests for the CLI code paths? I don't think it would be that hard (famous last words). |
Collaborator
Author
|
Agreed that tests for this area don’t seem that hard. |
Without this, `shiny run --app-dir=foo app.py` won't work even if foo/app.py exists and is a valid Shiny app. This is because the code that turns `app.py` into `app:app` for Uvicorn wasn't aware of --app-dir.
nealrichardson
force-pushed
the
app-path-with-app-file
branch
from
d71f466 to
2d82223
Compare
nealrichardson
approved these changes
Jul 13, 2023
Collaborator
nealrichardson
left a comment
nealrichardson
left a comment
There was a problem hiding this comment.
Works on my machine.
I just rebased on main to hopefully fix CI.
schloerke
added a commit
that referenced
this pull request
Jul 18, 2023
schloerke
added a commit
that referenced
this pull request
Jul 24, 2023
* main: Add E2E tests for accordion and autoresize (#601) Add card test (#622) Add sidebar test (#631) Make card fullscreen icon a tooltip (#632) Pull in changes from rstudio/bslib#697 and rstudio/bslib#699 Changelog tweak. Followup to #629 Add experimental tooltip methods and example apps (#629) Use `blib::bs_theme(5,"shiny")` for py-shiny theme (#624) Rename shiny/examples to shiny/api-examples (and X/examples to X/api-examples) (#627) Make --app-path work with app file argument (#598) Don't eval example code block Fix example code blocks (#626) Annotation export example (#584) Add todo list example (#603)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this,
shiny run --app-dir=foo app.pywon't work even if foo/app.py exists and is a valid Shiny app. This is because the code that turnsapp.pyintoapp:appfor Uvicorn wasn't aware of --app-dir.