Skip to content

fix(remove_all_fill): copy tag before modifying it #1539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 16, 2024
Merged

fix(remove_all_fill): copy tag before modifying it #1539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4534cf2
fix(remove_all_fill): copy `tag` before modify
gadenbuie Jul 16, 2024
e6313e2
docs: Add changelog item
gadenbuie Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

* Made sure all `@render.data_frame` cells that have been edited are now restored back to ready state to handle the off chance that the returned patches are at different locations the the original edit patches. (#1529)

* `remove_all_fill(tag)` no longer modifies the original `tag` input and instead returns a modified copy of `tag`. (#1538)


### Other changes

Expand Down
11 changes: 6 additions & 5 deletions shiny/ui/fill/_fill.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,8 +127,8 @@ def remove_all_fill(
Returns
-------
:
The original :class:`~htmltools.Tag` object with filling layout attributes
removed.
A copy of the original :class:`~htmltools.Tag` object with filling layout
attributes removed.


See Also
Expand All @@ -137,9 +137,10 @@ def remove_all_fill(
* :func:`~shiny.ui.fill.as_fillable_container`
"""

tag.remove_class(FILL_CONTAINER_CLASS)
tag.remove_class(FILL_ITEM_CLASS)
return tag
res = copy(tag)
res.remove_class(FILL_CONTAINER_CLASS)
res.remove_class(FILL_ITEM_CLASS)
return res


# Method currently not exposed, but implemented within bslib
Expand Down