From e0e26b43a9e0120ebe9e02b32a7476cd3da5149c Mon Sep 17 00:00:00 2001 From: Karan Gathani Date: Fri, 17 May 2024 11:56:04 -0700 Subject: [PATCH 1/2] Remove skip for webkit browser tests --- .../shiny/bugs/0696-resolve-id/test_0696_resolve_id.py | 1 - tests/playwright/shiny/components/nav/test_nav.py | 1 - 2 files changed, 2 deletions(-) diff --git a/tests/playwright/shiny/bugs/0696-resolve-id/test_0696_resolve_id.py b/tests/playwright/shiny/bugs/0696-resolve-id/test_0696_resolve_id.py index be00085ae..37bb2907c 100644 --- a/tests/playwright/shiny/bugs/0696-resolve-id/test_0696_resolve_id.py +++ b/tests/playwright/shiny/bugs/0696-resolve-id/test_0696_resolve_id.py @@ -109,7 +109,6 @@ def expect_default_outputs(page: Page, module_id: str): # Sidebars do not seem to work on webkit. Skipping test on webkit @pytest.mark.flaky(reruns=reruns, reruns_delay=reruns_delay) -@pytest.mark.skip_browser("webkit") def test_module_support(page: Page, local_app: ShinyAppProc) -> None: page.set_viewport_size({"width": 3000, "height": 6000}) page.goto(local_app.url) diff --git a/tests/playwright/shiny/components/nav/test_nav.py b/tests/playwright/shiny/components/nav/test_nav.py index 546f81090..948413c4f 100644 --- a/tests/playwright/shiny/components/nav/test_nav.py +++ b/tests/playwright/shiny/components/nav/test_nav.py @@ -17,7 +17,6 @@ from playwright.sync_api import Page -@pytest.mark.skip_browser("webkit") def test_nav(page: Page, local_app: ShinyAppProc) -> None: page.goto(local_app.url) From e756b3d0e1467d9108f1bdccf1badad9f991142e Mon Sep 17 00:00:00 2001 From: Karan Gathani Date: Fri, 17 May 2024 11:57:07 -0700 Subject: [PATCH 2/2] remove unnecessary import --- tests/playwright/shiny/components/nav/test_nav.py | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/playwright/shiny/components/nav/test_nav.py b/tests/playwright/shiny/components/nav/test_nav.py index 948413c4f..f32dfe4fb 100644 --- a/tests/playwright/shiny/components/nav/test_nav.py +++ b/tests/playwright/shiny/components/nav/test_nav.py @@ -2,7 +2,6 @@ from dataclasses import dataclass -import pytest from conftest import ShinyAppProc from controls import ( LayoutNavSetBar,