From 0b8c75c73e3aca1f8c0cff64b697b5d99ec5021c Mon Sep 17 00:00:00 2001 From: Karan Gathani Date: Fri, 17 May 2024 11:49:40 -0700 Subject: [PATCH 1/2] Fix output transformer auto registration --- shiny/render/transformer/_transformer.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/shiny/render/transformer/_transformer.py b/shiny/render/transformer/_transformer.py index 37118d315..635286ef7 100644 --- a/shiny/render/transformer/_transformer.py +++ b/shiny/render/transformer/_transformer.py @@ -266,8 +266,8 @@ def __init__( self._default_ui_args: tuple[object, ...] = tuple() self._default_ui_kwargs: dict[str, object] = dict() - # Allow for App authors to not require `@output` - self._auto_register() + # Register the value function with the parent Renderer class + self(value_fn) def _meta(self) -> TransformerMetadata: """ From ff96fcd7b3b101ffdf248fb6364f9f826d7cf996 Mon Sep 17 00:00:00 2001 From: Karan Gathani Date: Fri, 17 May 2024 11:49:57 -0700 Subject: [PATCH 2/2] Unskip broken tests --- .../output_transformer/test_output_transformer_example.py | 2 -- .../server/output_transformer/test_output_transformer_async.py | 2 -- 2 files changed, 4 deletions(-) diff --git a/tests/playwright/shiny/deprecated/output_transformer/test_output_transformer_example.py b/tests/playwright/shiny/deprecated/output_transformer/test_output_transformer_example.py index 57ef6857e..ca16acb10 100644 --- a/tests/playwright/shiny/deprecated/output_transformer/test_output_transformer_example.py +++ b/tests/playwright/shiny/deprecated/output_transformer/test_output_transformer_example.py @@ -1,10 +1,8 @@ -import pytest from conftest import ShinyAppProc from controls import OutputTextVerbatim from playwright.sync_api import Page -@pytest.mark.skip(reason="Flaky test. Fix before renabling") def test_output_image_kitchen(page: Page, local_app: ShinyAppProc) -> None: page.goto(local_app.url) diff --git a/tests/playwright/shiny/server/output_transformer/test_output_transformer_async.py b/tests/playwright/shiny/server/output_transformer/test_output_transformer_async.py index d6a57e566..11230bff1 100644 --- a/tests/playwright/shiny/server/output_transformer/test_output_transformer_async.py +++ b/tests/playwright/shiny/server/output_transformer/test_output_transformer_async.py @@ -1,10 +1,8 @@ -import pytest from conftest import ShinyAppProc from controls import OutputTextVerbatim from playwright.sync_api import Page -@pytest.mark.skip(reason="Flaky test. please fix before enabling") def test_output_transformer(page: Page, local_app: ShinyAppProc) -> None: page.goto(local_app.url)