From 7ea976388e7f1a433e1e7bc5d74113522b87ade0 Mon Sep 17 00:00:00 2001 From: Barret Schloerke Date: Thu, 28 Mar 2024 12:04:18 -0400 Subject: [PATCH 01/12] Init merge_group hook --- .github/workflows/build-docs.yaml | 7 ++++--- .github/workflows/pytest.yaml | 1 + .github/workflows/verify-js-built.yaml | 1 + 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build-docs.yaml b/.github/workflows/build-docs.yaml index c53dfd047..baa36b90a 100644 --- a/.github/workflows/build-docs.yaml +++ b/.github/workflows/build-docs.yaml @@ -5,6 +5,7 @@ on: push: branches: ["main"] pull_request: + merge_group: jobs: build: @@ -42,6 +43,7 @@ jobs: make quartodoc - name: Build site + if: github.event != 'merge_group' run: | cd docs make site @@ -52,15 +54,14 @@ jobs: with: path: "docs/_site" - deploy: if: github.ref == 'refs/heads/main' needs: build # Grant GITHUB_TOKEN the permissions required to make a Pages deployment permissions: - pages: write # to deploy to Pages - id-token: write # to verify the deployment originates from an appropriate source + pages: write # to deploy to Pages + id-token: write # to verify the deployment originates from an appropriate source # Deploy to the github-pages environment environment: diff --git a/.github/workflows/pytest.yaml b/.github/workflows/pytest.yaml index 833afe9e9..2ab433f48 100644 --- a/.github/workflows/pytest.yaml +++ b/.github/workflows/pytest.yaml @@ -5,6 +5,7 @@ on: push: branches: ["main", "rc-*"] pull_request: + merge_group: release: types: [published] schedule: diff --git a/.github/workflows/verify-js-built.yaml b/.github/workflows/verify-js-built.yaml index 87ef94435..71d1b4a7d 100644 --- a/.github/workflows/verify-js-built.yaml +++ b/.github/workflows/verify-js-built.yaml @@ -4,6 +4,7 @@ on: push: branches: ["main", "rc-*"] pull_request: + merge_group: jobs: verify_js_built: From eb48dd17ad31dfbec5e0370f47b3c2d752b9e9bb Mon Sep 17 00:00:00 2001 From: Barret Schloerke Date: Thu, 28 Mar 2024 12:06:20 -0400 Subject: [PATCH 02/12] Leverage merge_queue --- .github/py-shiny/pytest-browsers/action.yaml | 19 +++++++++++++++++++ .github/workflows/pytest.yaml | 8 ++++++-- Makefile | 12 ++++++------ pytest.ini | 3 ++- 4 files changed, 33 insertions(+), 9 deletions(-) create mode 100644 .github/py-shiny/pytest-browsers/action.yaml diff --git a/.github/py-shiny/pytest-browsers/action.yaml b/.github/py-shiny/pytest-browsers/action.yaml new file mode 100644 index 000000000..af3cb154c --- /dev/null +++ b/.github/py-shiny/pytest-browsers/action.yaml @@ -0,0 +1,19 @@ +name: 'Custom merge queue browsers' +description: 'Trim down pytest browsers to just chrome for merge_group events.' +outputs: + browsers: + description: 'pytest browsers to use' + value: ${{ steps.browsers.outputs.browser }} +runs: + using: "composite" + steps: + - name: Determine browsers to use + shell: bash + id: browsers + run: | + if [ "${{ github.event_name }}" == "merge_group" ]; then + echo "Using chrome browser only!" + echo 'browsers=PYTEST_BROWSER="--browser chromium"' >> "$GITHUB_OUTPUT" + else + echo "No custom pytest browsers" + fi diff --git a/.github/workflows/pytest.yaml b/.github/workflows/pytest.yaml index 2ab433f48..2f76395ab 100644 --- a/.github/workflows/pytest.yaml +++ b/.github/workflows/pytest.yaml @@ -65,10 +65,12 @@ jobs: with: python-version: ${{ matrix.python-version }} + - uses: ./.github/py-shiny/pytest-browers + id: browsers - name: Run End-to-End tests timeout-minutes: 20 run: | - make playwright-shiny SUB_FILE=". -vv" + make playwright-shiny SUB_FILE=". -vv" ${{ steps.browsers.outputs.browsers }} - uses: actions/upload-artifact@v4 if: failure() with: @@ -103,10 +105,12 @@ jobs: run: | npm ci + - uses: ./.github/py-shiny/pytest-browers + id: browsers - name: Run example app tests timeout-minutes: 20 run: | - make playwright-examples SUB_FILE=". -vv" + make playwright-examples SUB_FILE=". -vv" ${{ steps.browsers.outputs.browsers }} - uses: actions/upload-artifact@v4 if: failure() with: diff --git a/Makefile b/Makefile index adaedf299..0f183acfa 100644 --- a/Makefile +++ b/Makefile @@ -144,7 +144,7 @@ clean-js: FORCE # Default `SUB_FILE` to empty SUB_FILE:= - +PYTEST_BROWSERS:= --browser webkit --browser firefox --browser chromium install-playwright: FORCE playwright install --with-deps @@ -157,15 +157,15 @@ install-rsconnect: FORCE # end-to-end tests with playwright; (SUB_FILE="" within tests/playwright/shiny/) playwright-shiny: install-playwright - pytest tests/playwright/shiny/$(SUB_FILE) + pytest tests/playwright/shiny/$(SUB_FILE) $(PYTEST_BROWSERS) # end-to-end tests on deployed apps with playwright; (SUB_FILE="" within tests/playwright/deploys/) playwright-deploys: install-playwright install-rsconnect - pytest tests/playwright/deploys/$(SUB_FILE) + pytest tests/playwright/deploys/$(SUB_FILE) $(PYTEST_BROWSERS) # end-to-end tests on all py-shiny examples with playwright; (SUB_FILE="" within tests/playwright/examples/) playwright-examples: install-playwright - pytest tests/playwright/examples/$(SUB_FILE) + pytest tests/playwright/examples/$(SUB_FILE) $(PYTEST_BROWSERS) playwright-debug: install-playwright ## All end-to-end tests, chrome only, headed; (SUB_FILE="" within tests/playwright/) pytest -c tests/playwright/playwright-pytest.ini tests/playwright/$(SUB_FILE) @@ -175,10 +175,10 @@ playwright-show-trace: ## Show trace of failed tests # end-to-end tests with playwright and generate junit report testrail-junit: install-playwright install-trcli - pytest tests/playwright/shiny/$(SUB_FILE) --junitxml=report.xml + pytest tests/playwright/shiny/$(SUB_FILE) --junitxml=report.xml $(PYTEST_BROWSERS) coverage: FORCE ## check combined code coverage (must run e2e last) - pytest --cov-report term-missing --cov=shiny tests/pytest/ tests/playwright/shiny/$(SUB_FILE) + pytest --cov-report term-missing --cov=shiny tests/pytest/ tests/playwright/shiny/$(SUB_FILE) $(PYTEST_BROWSERS) coverage html $(BROWSER) htmlcov/index.html diff --git a/pytest.ini b/pytest.ini index 7efe317fc..1c02d79f4 100644 --- a/pytest.ini +++ b/pytest.ini @@ -1,4 +1,5 @@ [pytest] asyncio_mode=strict testpaths=tests/pytest/ -addopts = --strict-markers --durations=6 --durations-min=5.0 --browser webkit --browser firefox --browser chromium --numprocesses auto --tracing=retain-on-failure --video=retain-on-failure +; Note: Browsers are set within `./Makefile` +addopts = --strict-markers --durations=6 --durations-min=5.0 --numprocesses auto --tracing=retain-on-failure --video=retain-on-failure From 6a06c4d10d0f3ebc54709c2ca0d2e51d1792a0df Mon Sep 17 00:00:00 2001 From: Barret Schloerke Date: Thu, 28 Mar 2024 12:21:12 -0400 Subject: [PATCH 03/12] Fix typo --- .github/workflows/pytest.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pytest.yaml b/.github/workflows/pytest.yaml index 2f76395ab..c346d8be8 100644 --- a/.github/workflows/pytest.yaml +++ b/.github/workflows/pytest.yaml @@ -65,7 +65,7 @@ jobs: with: python-version: ${{ matrix.python-version }} - - uses: ./.github/py-shiny/pytest-browers + - uses: ./.github/py-shiny/pytest-browsers id: browsers - name: Run End-to-End tests timeout-minutes: 20 @@ -105,7 +105,7 @@ jobs: run: | npm ci - - uses: ./.github/py-shiny/pytest-browers + - uses: ./.github/py-shiny/pytest-browsers id: browsers - name: Run example app tests timeout-minutes: 20 From 71de5e0fa5b946b0e4812858af4245e0ec5012f3 Mon Sep 17 00:00:00 2001 From: Barret Schloerke Date: Thu, 28 Mar 2024 12:21:35 -0400 Subject: [PATCH 04/12] `actions/checkout@v3` -> `actions/checkout@v4` --- .github/workflows/build-docs.yaml | 2 +- .github/workflows/pytest.yaml | 14 +++++++------- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflows/build-docs.yaml b/.github/workflows/build-docs.yaml index baa36b90a..3beea0b11 100644 --- a/.github/workflows/build-docs.yaml +++ b/.github/workflows/build-docs.yaml @@ -16,7 +16,7 @@ jobs: fail-fast: false steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - name: Set up Python ${{ matrix.python-version }} uses: actions/setup-python@v4 diff --git a/.github/workflows/pytest.yaml b/.github/workflows/pytest.yaml index c346d8be8..3944deb79 100644 --- a/.github/workflows/pytest.yaml +++ b/.github/workflows/pytest.yaml @@ -22,7 +22,7 @@ jobs: fail-fast: false steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - name: Setup py-shiny id: install uses: ./.github/py-shiny/setup @@ -59,7 +59,7 @@ jobs: fail-fast: false steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - name: Setup py-shiny uses: ./.github/py-shiny/setup with: @@ -88,7 +88,7 @@ jobs: fail-fast: false steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - name: Setup py-shiny uses: ./.github/py-shiny/setup with: @@ -129,7 +129,7 @@ jobs: fail-fast: false steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - name: Setup py-shiny uses: ./.github/py-shiny/setup with: @@ -164,7 +164,7 @@ jobs: fail-fast: false steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - name: Setup py-shiny uses: ./.github/py-shiny/setup with: @@ -204,7 +204,7 @@ jobs: if: github.event_name == 'release' needs: [build] steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - name: "Set up Python 3.10" uses: actions/setup-python@v4 with: @@ -251,7 +251,7 @@ jobs: fail-fast: false steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - name: Setup py-shiny uses: ./.github/py-shiny/setup with: From 799112764ca56e4964d6488b6d4368871d5bef8d Mon Sep 17 00:00:00 2001 From: Barret Schloerke Date: Thu, 28 Mar 2024 12:28:42 -0400 Subject: [PATCH 05/12] Invert inverted logic; Put slow events on merge_group --- .github/py-shiny/pytest-browsers/action.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/py-shiny/pytest-browsers/action.yaml b/.github/py-shiny/pytest-browsers/action.yaml index af3cb154c..7ca7d801c 100644 --- a/.github/py-shiny/pytest-browsers/action.yaml +++ b/.github/py-shiny/pytest-browsers/action.yaml @@ -1,5 +1,5 @@ name: 'Custom merge queue browsers' -description: 'Trim down pytest browsers to just chrome for merge_group events.' +description: 'Trim down pytest browsers for any github event other than merge_group.' outputs: browsers: description: 'pytest browsers to use' @@ -11,7 +11,7 @@ runs: shell: bash id: browsers run: | - if [ "${{ github.event_name }}" == "merge_group" ]; then + if [ "${{ github.event_name }}" != "merge_group" ]; then echo "Using chrome browser only!" echo 'browsers=PYTEST_BROWSER="--browser chromium"' >> "$GITHUB_OUTPUT" else From 7bf544d0018a7894afcb38c347c5636a5f3888b2 Mon Sep 17 00:00:00 2001 From: Barret Schloerke Date: Thu, 28 Mar 2024 12:28:47 -0400 Subject: [PATCH 06/12] Update pytest.yaml --- .github/workflows/pytest.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/pytest.yaml b/.github/workflows/pytest.yaml index 3944deb79..410fc5b53 100644 --- a/.github/workflows/pytest.yaml +++ b/.github/workflows/pytest.yaml @@ -151,7 +151,7 @@ jobs: playwright-deploys: needs: [playwright-deploys-precheck] - if: github.event_name != 'release' && (github.event_name == 'push' || (github.event_name == 'pull_request' && startsWith(github.head_ref, 'deploy'))) + if: github.event_name != 'release' && (github.event_name == 'push' || startsWith(github.head_ref, 'deploy')) # Only allow one `playwright-deploys` job to run at a time. (Independent of branch / PR) # Only one is allowed to run at a time because it is deploying to the same server location. concurrency: playwright-deploys @@ -177,7 +177,7 @@ jobs: run: | make playwright-deploys SUB_FILE=". -vv" - - name: Deploy apps and run tests (on `push` or on `pull_request` w/ `deploy**` branch) + - name: Deploy apps and run tests (on `push` or `deploy**` branches) env: DEPLOY_APPS: "true" DEPLOY_CONNECT_SERVER_URL: "https://rsc.radixu.com/" @@ -238,7 +238,7 @@ jobs: testrail-reporting-nightly: runs-on: ${{ matrix.os }} - if: ${{ github.event_name == 'schedule' || (github.event_name == 'pull_request' && startsWith(github.head_ref, 'testrail')) }} + if: ${{ github.event_name == 'schedule' || startsWith(github.head_ref, 'testrail') }} strategy: matrix: python-version: From d62554bd9fbad7cb7a23b7ab2cdd4eff1159217a Mon Sep 17 00:00:00 2001 From: Barret Schloerke Date: Thu, 28 Mar 2024 12:45:32 -0400 Subject: [PATCH 07/12] Update action.yaml --- .github/py-shiny/pytest-browsers/action.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/py-shiny/pytest-browsers/action.yaml b/.github/py-shiny/pytest-browsers/action.yaml index 7ca7d801c..21ab8d1e5 100644 --- a/.github/py-shiny/pytest-browsers/action.yaml +++ b/.github/py-shiny/pytest-browsers/action.yaml @@ -3,7 +3,7 @@ description: 'Trim down pytest browsers for any github event other than merge_gr outputs: browsers: description: 'pytest browsers to use' - value: ${{ steps.browsers.outputs.browser }} + value: ${{ steps.browsers.outputs.browsers }} runs: using: "composite" steps: From 69c1577aa3a25aef42e29fd5032d8958b4fed271 Mon Sep 17 00:00:00 2001 From: Barret Schloerke Date: Thu, 28 Mar 2024 13:20:43 -0400 Subject: [PATCH 08/12] Allow branches that start with `playwright` to test on all browsers --- .github/py-shiny/pytest-browsers/action.yaml | 21 +++++++++++++++----- .github/workflows/pytest.yaml | 10 ++++++++-- 2 files changed, 24 insertions(+), 7 deletions(-) diff --git a/.github/py-shiny/pytest-browsers/action.yaml b/.github/py-shiny/pytest-browsers/action.yaml index 21ab8d1e5..de52d959e 100644 --- a/.github/py-shiny/pytest-browsers/action.yaml +++ b/.github/py-shiny/pytest-browsers/action.yaml @@ -1,5 +1,10 @@ name: 'Custom merge queue browsers' description: 'Trim down pytest browsers for any github event other than merge_group.' +inputs: + all-browsers: + description: 'Force all pytest browsers to used when testing' + required: false + default: 'false' outputs: browsers: description: 'pytest browsers to use' @@ -11,9 +16,15 @@ runs: shell: bash id: browsers run: | - if [ "${{ github.event_name }}" != "merge_group" ]; then - echo "Using chrome browser only!" - echo 'browsers=PYTEST_BROWSER="--browser chromium"' >> "$GITHUB_OUTPUT" - else - echo "No custom pytest browsers" + if [ "${{ inputs.all-browsers }}" == "true" ]; then + echo "Using all browsers!" + exit 0 fi + + if [ "${{ github.event_name }}" == "merge_group" ]; then + echo "No custom pytest browsers for merge_group event!" + exit 0 + fi + + echo "Using chrome browser only!" + echo 'browsers=PYTEST_BROWSER="--browser chromium"' >> "$GITHUB_OUTPUT" diff --git a/.github/workflows/pytest.yaml b/.github/workflows/pytest.yaml index 410fc5b53..f5e38c14e 100644 --- a/.github/workflows/pytest.yaml +++ b/.github/workflows/pytest.yaml @@ -65,8 +65,11 @@ jobs: with: python-version: ${{ matrix.python-version }} - - uses: ./.github/py-shiny/pytest-browsers + - name: Determine browsers for testing + uses: ./.github/py-shiny/pytest-browsers id: browsers + with: + all-browsers: ${{ startsWith(github.head_ref, 'playwright') }} - name: Run End-to-End tests timeout-minutes: 20 run: | @@ -105,8 +108,11 @@ jobs: run: | npm ci - - uses: ./.github/py-shiny/pytest-browsers + - name: Determine browsers for testing + uses: ./.github/py-shiny/pytest-browsers id: browsers + with: + all-browsers: ${{ startsWith(github.head_ref, 'playwright') }} - name: Run example app tests timeout-minutes: 20 run: | From 48b47c7b70fe72548a7502deca0f90ed7723db0f Mon Sep 17 00:00:00 2001 From: Barret Schloerke Date: Thu, 28 Mar 2024 13:25:42 -0400 Subject: [PATCH 09/12] test(CI): merge queue Test 1 (#1260) --- .github/py-shiny/pytest-browsers/action.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/py-shiny/pytest-browsers/action.yaml b/.github/py-shiny/pytest-browsers/action.yaml index de52d959e..33da0d0ad 100644 --- a/.github/py-shiny/pytest-browsers/action.yaml +++ b/.github/py-shiny/pytest-browsers/action.yaml @@ -10,7 +10,7 @@ outputs: description: 'pytest browsers to use' value: ${{ steps.browsers.outputs.browsers }} runs: - using: "composite" + using: 'composite' steps: - name: Determine browsers to use shell: bash From 893e05d80b950fca34b381383b992b9434d0e7df Mon Sep 17 00:00:00 2001 From: Barret Schloerke Date: Thu, 28 Mar 2024 13:25:47 -0400 Subject: [PATCH 10/12] test(CI): Merge queue test 2 (#1261) --- .github/py-shiny/pytest-browsers/action.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/py-shiny/pytest-browsers/action.yaml b/.github/py-shiny/pytest-browsers/action.yaml index 33da0d0ad..8be68fe6d 100644 --- a/.github/py-shiny/pytest-browsers/action.yaml +++ b/.github/py-shiny/pytest-browsers/action.yaml @@ -1,5 +1,5 @@ name: 'Custom merge queue browsers' -description: 'Trim down pytest browsers for any github event other than merge_group.' +description: 'Trim down pytest browsers for any github event other than merge_group' inputs: all-browsers: description: 'Force all pytest browsers to used when testing' From c1ebce92b059d60c15a60bf260afb5784e257ce8 Mon Sep 17 00:00:00 2001 From: Barret Schloerke Date: Thu, 28 Mar 2024 15:39:53 -0400 Subject: [PATCH 11/12] test(CI): merge queue Test 2.1 (#1264) --- .github/py-shiny/pytest-browsers/action.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/py-shiny/pytest-browsers/action.yaml b/.github/py-shiny/pytest-browsers/action.yaml index 8be68fe6d..33da0d0ad 100644 --- a/.github/py-shiny/pytest-browsers/action.yaml +++ b/.github/py-shiny/pytest-browsers/action.yaml @@ -1,5 +1,5 @@ name: 'Custom merge queue browsers' -description: 'Trim down pytest browsers for any github event other than merge_group' +description: 'Trim down pytest browsers for any github event other than merge_group.' inputs: all-browsers: description: 'Force all pytest browsers to used when testing' From a9b94f8b1bc5cc2770123624bf5413464c2a5952 Mon Sep 17 00:00:00 2001 From: Barret Schloerke Date: Thu, 28 Mar 2024 15:39:54 -0400 Subject: [PATCH 12/12] test(CI): merge queue Test 1.1 (#1263) --- .github/py-shiny/pytest-browsers/action.yaml | 12 ++++++------ .github/workflows/build-docs.yaml | 6 +++--- .github/workflows/pytest.yaml | 11 +++++++---- .github/workflows/verify-js-built.yaml | 2 +- 4 files changed, 17 insertions(+), 14 deletions(-) diff --git a/.github/py-shiny/pytest-browsers/action.yaml b/.github/py-shiny/pytest-browsers/action.yaml index 33da0d0ad..b9f470277 100644 --- a/.github/py-shiny/pytest-browsers/action.yaml +++ b/.github/py-shiny/pytest-browsers/action.yaml @@ -10,7 +10,7 @@ outputs: description: 'pytest browsers to use' value: ${{ steps.browsers.outputs.browsers }} runs: - using: 'composite' + using: "composite" steps: - name: Determine browsers to use shell: bash @@ -21,10 +21,10 @@ runs: exit 0 fi - if [ "${{ github.event_name }}" == "merge_group" ]; then - echo "No custom pytest browsers for merge_group event!" - exit 0 + if [ "${{ github.event_name }}" == "pull_request" ]; then + echo "Using chrome browser only!" + echo 'browsers=PYTEST_BROWSERS="--browser chromium"' >> "$GITHUB_OUTPUT" fi - echo "Using chrome browser only!" - echo 'browsers=PYTEST_BROWSER="--browser chromium"' >> "$GITHUB_OUTPUT" + echo "No custom pytest browsers!" + exit 0 diff --git a/.github/workflows/build-docs.yaml b/.github/workflows/build-docs.yaml index 3beea0b11..7cc001a61 100644 --- a/.github/workflows/build-docs.yaml +++ b/.github/workflows/build-docs.yaml @@ -8,7 +8,7 @@ on: merge_group: jobs: - build: + build-docs: runs-on: ubuntu-latest strategy: matrix: @@ -43,7 +43,7 @@ jobs: make quartodoc - name: Build site - if: github.event != 'merge_group' + if: ${{ github.event_name != 'pull_request' || startsWith(github.head_ref, 'docs') }} run: | cd docs make site @@ -56,7 +56,7 @@ jobs: deploy: if: github.ref == 'refs/heads/main' - needs: build + needs: build-docs # Grant GITHUB_TOKEN the permissions required to make a Pages deployment permissions: diff --git a/.github/workflows/pytest.yaml b/.github/workflows/pytest.yaml index f5e38c14e..ddc857c25 100644 --- a/.github/workflows/pytest.yaml +++ b/.github/workflows/pytest.yaml @@ -12,7 +12,7 @@ on: - cron: "0 8 * * *" jobs: - build: + check: runs-on: ubuntu-latest strategy: matrix: @@ -70,6 +70,9 @@ jobs: id: browsers with: all-browsers: ${{ startsWith(github.head_ref, 'playwright') }} + - name: Display browser + shell: bash + run: echo '${{ steps.browsers.outputs.browsers }}' - name: Run End-to-End tests timeout-minutes: 20 run: | @@ -98,7 +101,7 @@ jobs: python-version: ${{ matrix.python-version }} - name: Install node.js - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: node-version: "18" cache: npm @@ -208,7 +211,7 @@ jobs: name: "Deploy to PyPI" runs-on: ubuntu-latest if: github.event_name == 'release' - needs: [build] + needs: [check] steps: - uses: actions/checkout@v4 - name: "Set up Python 3.10" @@ -264,7 +267,7 @@ jobs: python-version: ${{ matrix.python-version }} - name: Install node.js - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: node-version: "18" cache: npm diff --git a/.github/workflows/verify-js-built.yaml b/.github/workflows/verify-js-built.yaml index 71d1b4a7d..d38cd1a7d 100644 --- a/.github/workflows/verify-js-built.yaml +++ b/.github/workflows/verify-js-built.yaml @@ -1,4 +1,4 @@ -name: Build +name: Verify built assets on: push: