Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/py-shiny/pytest-browsers/action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ outputs:
description: 'pytest browsers to use'
value: ${{ steps.browsers.outputs.browsers }}
runs:
using: 'composite'
using: "composite"
steps:
- name: Determine browsers to use
shell: bash
Expand All @@ -21,10 +21,10 @@ runs:
exit 0
fi

if [ "${{ github.event_name }}" == "merge_group" ]; then
echo "No custom pytest browsers for merge_group event!"
exit 0
if [ "${{ github.event_name }}" == "pull_request" ]; then
echo "Using chrome browser only!"
echo 'browsers=PYTEST_BROWSERS="--browser chromium"' >> "$GITHUB_OUTPUT"
fi

echo "Using chrome browser only!"
echo 'browsers=PYTEST_BROWSER="--browser chromium"' >> "$GITHUB_OUTPUT"
echo "No custom pytest browsers!"
exit 0
6 changes: 3 additions & 3 deletions .github/workflows/build-docs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:
merge_group:

jobs:
build:
build-docs:
runs-on: ubuntu-latest
strategy:
matrix:
Expand Down Expand Up @@ -43,7 +43,7 @@ jobs:
make quartodoc

- name: Build site
if: github.event != 'merge_group'
if: ${{ github.event_name != 'pull_request' || startsWith(github.head_ref, 'docs') }}
run: |
cd docs
make site
Expand All @@ -56,7 +56,7 @@ jobs:

deploy:
if: github.ref == 'refs/heads/main'
needs: build
needs: build-docs

# Grant GITHUB_TOKEN the permissions required to make a Pages deployment
permissions:
Expand Down
11 changes: 7 additions & 4 deletions .github/workflows/pytest.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ on:
- cron: "0 8 * * *"

jobs:
build:
check:
runs-on: ubuntu-latest
strategy:
matrix:
Expand Down Expand Up @@ -70,6 +70,9 @@ jobs:
id: browsers
with:
all-browsers: ${{ startsWith(github.head_ref, 'playwright') }}
- name: Display browser
shell: bash
run: echo '${{ steps.browsers.outputs.browsers }}'
- name: Run End-to-End tests
timeout-minutes: 20
run: |
Expand Down Expand Up @@ -98,7 +101,7 @@ jobs:
python-version: ${{ matrix.python-version }}

- name: Install node.js
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: "18"
cache: npm
Expand Down Expand Up @@ -208,7 +211,7 @@ jobs:
name: "Deploy to PyPI"
runs-on: ubuntu-latest
if: github.event_name == 'release'
needs: [build]
needs: [check]
steps:
- uses: actions/checkout@v4
- name: "Set up Python 3.10"
Expand Down Expand Up @@ -264,7 +267,7 @@ jobs:
python-version: ${{ matrix.python-version }}

- name: Install node.js
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: "18"
cache: npm
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/verify-js-built.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Build
name: Verify built assets

on:
push:
Expand Down