From 2a6e24850062094fb3de01ef6704a377c3f58b1a Mon Sep 17 00:00:00 2001 From: Barret Schloerke Date: Fri, 22 Mar 2024 23:04:42 -0400 Subject: [PATCH 1/2] Disable broken test on ci as debugging has not given any leads --- .../shiny/session/flush/test_on_flush.py | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/tests/playwright/shiny/session/flush/test_on_flush.py b/tests/playwright/shiny/session/flush/test_on_flush.py index b59feced9..4e782a814 100644 --- a/tests/playwright/shiny/session/flush/test_on_flush.py +++ b/tests/playwright/shiny/session/flush/test_on_flush.py @@ -1,9 +1,26 @@ +import os + +import pytest from conftest import ShinyAppProc from controls import OutputTextVerbatim from playwright.sync_api import Page +on_ci = os.environ.get("CI", "False") == "true" + def test_output_image_kitchen(page: Page, local_app: ShinyAppProc) -> None: + + if on_ci: + # 2024-03-22: The tests pass locally, but do not pass on CI. It started with + # https://github.com/posit-dev/py-shiny/commit/2f75a9076c567690f2a6a647ec07cfa9e558ff9c + # , but the changes in that commit were unrelated. We had believe it was an + # update in uvicorn, but removing all other debug statements did not fix the + # issue. + # 2024-03-22 Barret: When inspecting the issue, we found that many log + # INFO entries have different port values. This is concerning. + # https://github.com/posit-dev/py-shiny/pull/1236 + pytest.skip("Error with stdout / stderr on CI. Related #1236") + page.goto(local_app.url) OutputTextVerbatim(page, "all_txt").expect_value( From 24471c734f9058edae43a1c0ad5e96150261c3a3 Mon Sep 17 00:00:00 2001 From: Barret Schloerke Date: Fri, 22 Mar 2024 23:11:23 -0400 Subject: [PATCH 2/2] Fix broken docs links Followup to #1239 --- docs/_quartodoc-core.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/docs/_quartodoc-core.yml b/docs/_quartodoc-core.yml index 309fcf07d..28927e4e8 100644 --- a/docs/_quartodoc-core.yml +++ b/docs/_quartodoc-core.yml @@ -235,13 +235,13 @@ quartodoc: - session.get_current_session - session.require_active_session - session.session_context - - session.send_custom_message - - session.send_input_message - - session.on_flush - - session.on_flushed - - session.on_ended - - session.dynamic_route - reactive.get_current_context + - session.Session.send_custom_message + - session.Session.send_input_message + - session.Session.on_flush + - session.Session.on_flushed + - session.Session.on_ended + - session.Session.dynamic_route - name: input_handler.input_handlers dynamic: true - kind: page