Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,18 +9,26 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Breaking Changes

* `ui.page_sidebar()` now places the `title` element in a `.navbar` container that matches the structure of `page_navbar()`. This ensures that the title elements of `page_sidebar()` and `page_navbar()` have consistent appearance. (#1176)

### New features

### Bug fixes

* Shiny now compiles the Bootstrap 5-based stylesheets for component styles imported from https://github.com/rstudio/shiny. (#1191)

* Fixed the CSS for `ui.output_ui()` to avoid unwanted double padding when its parent container uses `gap` for spacing multiple elements (e.g., `ui.layout_columns()`, `ui.page_fillable()`, etc). (#1176)

### Other changes

* Closed #1178: Removed run-time dependency on asgiref. (#1183)

* The uvicorn and click packages are no longer needed when running on Emscripten. (#1187)

* We adjusted the shadows used for cards and popovers. Cards now use a slightly smaller shadow and the same shadow style is also now used by popovers. (#1176)

* We increased the spacing between elements just slightly. This change is most noticeable in the `layout_columns()` or `layout_column_wrap()` component. In these and other components, you can use `gap` and `padding` arguments to choose your own values, or you can set the `$bslib-spacer` (Sass) or `--bslib-spacer` (CSS) variable. (#1176)

## [0.8.0] - 2024-03-04

### Breaking Changes
Expand Down
14 changes: 10 additions & 4 deletions shiny/ui/_page.py
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,15 @@ def page_sidebar(
"""

if isinstance(title, str):
title = tags.h1(title, class_="bslib-page-title")
title = tags.h1(title, class_="bslib-page-title navbar-brand")

if title is not None:
navbar_title = tags.div(
tags.div(title, class_="container-fluid"),
class_="navbar navbar-static-top",
)
else:
navbar_title = None

if not isinstance(sidebar, Sidebar):
raise TypeError(
Expand All @@ -103,12 +111,10 @@ def page_sidebar(

return page_fillable(
{"class": "bslib-page-sidebar"},
title,
navbar_title,
layout_sidebar(
sidebar,
*children,
# Make the main area background white instead of the default gray.
{"style": "--bslib-shiny-preset-main-bg: white;"},
attrs,
fillable=fillable,
border=False,
Expand Down
2 changes: 1 addition & 1 deletion shiny/www/shared/bootstrap/_version.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"note!": "This file is auto-generated by scripts/htmlDependencies.R",
"shiny_version": "Github (rstudio/shiny@6760c318184535185e5050aefe29e658e8710ef0)",
"bslib_version": "Github (rstudio/bslib@243499ae83509ce0fe66d36488b0e20e8c227e26)",
"bslib_version": "Github (rstudio/bslib@fb94eba42c5d219350882420f49de25ebfebe698)",
"htmltools_version": "CRAN (R 4.3.1)",
"bootstrap_version": "5.3.1"
}
2 changes: 1 addition & 1 deletion shiny/www/shared/bootstrap/bootstrap.min.css

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion shiny/www/shared/bslib/_version.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"note!": "This file is auto-generated by scripts/htmlDependencies.R",
"package": "bslib",
"version": "Github (rstudio/bslib@243499ae83509ce0fe66d36488b0e20e8c227e26)"
"version": "Github (rstudio/bslib@fb94eba42c5d219350882420f49de25ebfebe698)"
}
2 changes: 1 addition & 1 deletion shiny/www/shared/bslib/components/components.css

Large diffs are not rendered by default.