Don't error on malformed date input #1139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
LGTM |
schloerke
added a commit
that referenced
this pull request
Feb 27, 2024
* main: Update `@render.data_frame` renderer to work properly with fill/fillable (#1126) Don't error on malformed date input (#1139) fix(nav_panel): Add `.bslib-gap-spacing` if nav panel is fillable (#1154) feat: Add `ui.input_dark_mode()` (#1149) chore(make): Add `make docs` and `make docs-preview` (#1150) Sync with latest bslib sidebar and card changes (#1129) docs(input_task_button): Add to reference index, also update methods for action button/link (#1151) chore(make): Update check and check-fix to replicate CI (#1148)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1138.
This returns
Nonefor each malformed date component. If it's a date range, then it returns a length-2 tuple where either or both components could beNone. I thought this behavior seemed reasonable, but I'm open to other ideas. Another possibility is to simply not change and invalidateinput.x()until there's a valid value, but I think that fix would be a bit more involved.Update: I've thought about this a bit more, and I think the behavior in this PR is what we should go with -- the UI component can have an empty value, and I think it makes sense to reflect that in the server-side input value (as opposed to not changing the input value until there's a valid value in the UI).