From 8ebcac7fba1dc0e0ba7d7f01ad6a2fdeb484f098 Mon Sep 17 00:00:00 2001 From: Barret Schloerke Date: Thu, 15 Feb 2024 10:55:04 -0500 Subject: [PATCH 1/3] Do not use the module prefix in the name --- shiny/session/_session.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/shiny/session/_session.py b/shiny/session/_session.py index c8647345e..12bc3e578 100644 --- a/shiny/session/_session.py +++ b/shiny/session/_session.py @@ -1071,7 +1071,7 @@ def set_renderer(renderer: RendererT) -> RendererT: output_name = self._ns(output_id) # renderer is a Renderer object. Give it a bit of metadata. - renderer._set_output_metadata(output_id=output_name) + renderer._set_output_metadata(output_id=output_id) renderer._on_register() From f3a833cca08d51c21557da6950a29414cd186865 Mon Sep 17 00:00:00 2001 From: Barret Schloerke Date: Thu, 15 Feb 2024 10:57:34 -0500 Subject: [PATCH 2/3] Update CHANGELOG.md --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8f8748f92..7e653ee75 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 * Fixed `input_task_button` not working in a Shiny module. (#1108) * Fixed several issues with `page_navbar()` styling. (#1124) +* Fixed `Renderer.output_id` to not contain the module namespace prefix, only the output id. (#1130) ## [0.7.1] - 2024-02-05 From 804ac2485164f957efeb4a8c045c29fbfb6a1eae Mon Sep 17 00:00:00 2001 From: Barret Schloerke Date: Fri, 16 Feb 2024 11:13:34 -0500 Subject: [PATCH 3/3] Update _render.py --- shiny/render/_render.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/shiny/render/_render.py b/shiny/render/_render.py index 7a1854d2e..20f793a54 100644 --- a/shiny/render/_render.py +++ b/shiny/render/_render.py @@ -281,6 +281,8 @@ async def render(self) -> dict[str, Jsonifiable] | Jsonifiable | None: is_userfn_async = self.fn.is_async() name = self.output_id session = require_active_session(None) + # Module support + name = session.ns(name) width = self.width height = self.height alt = self.alt