Skip to content

Fixes for flake8 #1012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 16, 2024
Merged

Fixes for flake8 #1012

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ede4fe2
Fixes for flake8
wch Jan 16, 2024
976061f
Raise if AsyncValueFn is passed an AsyncValueFn
wch Jan 16, 2024
56e4918
Merge branch 'main' into fix-flake8
schloerke Jan 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions shiny/_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,7 @@ def _step(fut: Optional["asyncio.Future[None]"] = None):
assert fut.done()
try:
fut.result()
except BaseException as e:
except BaseException as e: # noqa: B036
exc = e

if result_future.cancelled():
Expand All @@ -419,7 +419,7 @@ def _step(fut: Optional["asyncio.Future[None]"] = None):
except (KeyboardInterrupt, SystemExit) as e:
result_future.set_exception(e)
raise
except BaseException as e:
except BaseException as e: # noqa: B036
result_future.set_exception(e)
else:
# If we get here, the coro didn't finish. Schedule it for completion.
Expand Down
4 changes: 3 additions & 1 deletion shiny/render/renderer/_renderer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,9 @@ class AsyncValueFn(Generic[IT]):

def __init__(self, fn: Callable[[], IT] | Callable[[], Awaitable[IT]]):
if isinstance(fn, AsyncValueFn):
return cast(AsyncValueFn[IT], fn)
raise TypeError(
"Must not call `AsyncValueFn.__init__` with an object of class `AsyncValueFn`"
)
self._is_async = is_async_callable(fn)
self._fn = wrap_async(fn)
self._orig_fn = fn
Expand Down