Skip to content

Commit d750b84

Browse files
authored
bug(data frame): Fix Firefox rendering of textarea in editing cell (#1292)
1 parent c083bf0 commit d750b84

File tree

3 files changed

+13
-4
lines changed

3 files changed

+13
-4
lines changed

js/dataframe/styles.scss

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -291,7 +291,13 @@ shiny-data-frame .shiny-data-grid > table > tbody > tr > td.cell-edit-editing {
291291
& > textarea {
292292
position: absolute;
293293
padding: var(--shiny-datagrid-padding);
294-
inset: 0px;
294+
// We could use `inset: 0px`, but firefox doesn't render it properly.
295+
// Instead, use top, left, width, height
296+
top: 0;
297+
left: 0;
298+
width: 100%;
299+
height: 100%;
300+
295301
border: none;
296302

297303
background-color: inherit;

shiny/www/shared/py-shiny/dataframe/dataframe.js

Lines changed: 4 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

shiny/www/shared/py-shiny/dataframe/dataframe.js.map

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)