Skip to content

Commit 7de8661

Browse files
authored
test(CI): merge queue Test 1.1 (#1263)
1 parent ac3953c commit 7de8661

File tree

4 files changed

+17
-14
lines changed

4 files changed

+17
-14
lines changed

.github/py-shiny/pytest-browsers/action.yaml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ outputs:
1010
description: 'pytest browsers to use'
1111
value: ${{ steps.browsers.outputs.browsers }}
1212
runs:
13-
using: 'composite'
13+
using: "composite"
1414
steps:
1515
- name: Determine browsers to use
1616
shell: bash
@@ -21,10 +21,10 @@ runs:
2121
exit 0
2222
fi
2323
24-
if [ "${{ github.event_name }}" == "merge_group" ]; then
25-
echo "No custom pytest browsers for merge_group event!"
26-
exit 0
24+
if [ "${{ github.event_name }}" == "pull_request" ]; then
25+
echo "Using chrome browser only!"
26+
echo 'browsers=PYTEST_BROWSERS="--browser chromium"' >> "$GITHUB_OUTPUT"
2727
fi
2828
29-
echo "Using chrome browser only!"
30-
echo 'browsers=PYTEST_BROWSER="--browser chromium"' >> "$GITHUB_OUTPUT"
29+
echo "No custom pytest browsers!"
30+
exit 0

.github/workflows/build-docs.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ on:
88
merge_group:
99

1010
jobs:
11-
build:
11+
build-docs:
1212
runs-on: ubuntu-latest
1313
strategy:
1414
matrix:
@@ -43,7 +43,7 @@ jobs:
4343
make quartodoc
4444
4545
- name: Build site
46-
if: github.event != 'merge_group'
46+
if: ${{ github.event_name != 'pull_request' || startsWith(github.head_ref, 'docs') }}
4747
run: |
4848
cd docs
4949
make site
@@ -56,7 +56,7 @@ jobs:
5656

5757
deploy:
5858
if: github.ref == 'refs/heads/main'
59-
needs: build
59+
needs: build-docs
6060

6161
# Grant GITHUB_TOKEN the permissions required to make a Pages deployment
6262
permissions:

.github/workflows/pytest.yaml

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ on:
1212
- cron: "0 8 * * *"
1313

1414
jobs:
15-
build:
15+
check:
1616
runs-on: ubuntu-latest
1717
strategy:
1818
matrix:
@@ -70,6 +70,9 @@ jobs:
7070
id: browsers
7171
with:
7272
all-browsers: ${{ startsWith(github.head_ref, 'playwright') }}
73+
- name: Display browser
74+
shell: bash
75+
run: echo '${{ steps.browsers.outputs.browsers }}'
7376
- name: Run End-to-End tests
7477
timeout-minutes: 20
7578
run: |
@@ -98,7 +101,7 @@ jobs:
98101
python-version: ${{ matrix.python-version }}
99102

100103
- name: Install node.js
101-
uses: actions/setup-node@v3
104+
uses: actions/setup-node@v4
102105
with:
103106
node-version: "18"
104107
cache: npm
@@ -208,7 +211,7 @@ jobs:
208211
name: "Deploy to PyPI"
209212
runs-on: ubuntu-latest
210213
if: github.event_name == 'release'
211-
needs: [build]
214+
needs: [check]
212215
steps:
213216
- uses: actions/checkout@v4
214217
- name: "Set up Python 3.10"
@@ -264,7 +267,7 @@ jobs:
264267
python-version: ${{ matrix.python-version }}
265268

266269
- name: Install node.js
267-
uses: actions/setup-node@v3
270+
uses: actions/setup-node@v4
268271
with:
269272
node-version: "18"
270273
cache: npm

.github/workflows/verify-js-built.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: Build
1+
name: Verify built assets
22

33
on:
44
push:

0 commit comments

Comments
 (0)