Skip to content

Commit 789049c

Browse files
authored
Make card fullscreen icon a tooltip (#632)
1 parent 5cfb9f3 commit 789049c

File tree

5 files changed

+13
-14
lines changed

5 files changed

+13
-14
lines changed

shiny/experimental/ui/_card.py

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
from ._css_unit import CssUnit, as_css_padding, as_css_unit
2424
from ._fill import as_fill_carrier, as_fill_item, as_fillable_container
2525
from ._htmldeps import card_dependency
26+
from ._tooltip import tooltip
2627
from ._utils import consolidate_attrs
2728

2829
__all__ = (
@@ -135,14 +136,12 @@ def _card_js_init() -> Tag:
135136

136137

137138
def _full_screen_toggle() -> Tag:
138-
return tags.span(
139-
{
140-
"class": "bslib-full-screen-enter badge rounded-pill bg-dark",
141-
"data-bs-toggle": "tooltip",
142-
"data-bs-placement": "bottom",
143-
"title": "Expand",
144-
},
145-
_full_screen_toggle_icon(),
139+
return tooltip(
140+
tags.span(
141+
{"class": "bslib-full-screen-enter badge rounded-pill bg-dark"},
142+
_full_screen_toggle_icon(),
143+
),
144+
"Expand",
146145
)
147146

148147

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
22
"note!": "This file is auto-generated by scripts/htmlDependencies.R",
33
"package": "bslib",
4-
"version": "Github (rstudio/bslib@d54d2ddc50bf9956ef4090bb5bc31e81f9b08bdd)"
4+
"version": "Github (rstudio/bslib@eeade07b0d5da324718c647dd23f6792f4721642)"
55
}

shiny/experimental/www/bslib/components/card/card.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)