Skip to content

Commit 769b36b

Browse files
tests(navsets): Add navsets kitchensink tests (#1602)
Co-authored-by: Barret Schloerke <[email protected]>
1 parent 6e7c468 commit 769b36b

File tree

13 files changed

+698
-29
lines changed

13 files changed

+698
-29
lines changed

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
3333

3434
* Some copies of Windows 10 have registry entries mapping .js files to content type "text/plain", which was causing all sorts of problems for browsers. (#1624)
3535

36+
* Added missing support for `express.ui.navset_card_pill(placement:)`. (#1602)
37+
38+
* Added `.expect_sidebar()` and `.expect_title()` methods for `NavsetCardTab`, `NavsetCardPill`, `NavsetCardUnderline`, and `NavsetBar`. (#1602)
39+
40+
* Added `.expect_placement()` method for `NavsetCardPill` and `NavsetCardUnderline`. (#1602)
41+
3642
### Deprecations
3743

3844
## [1.0.0] - 2024-07-18

docs/_quartodoc-testing.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@ quartodoc:
4848
- title: Navigation (tab) panels
4949
desc: Methods for interacting with Shiny app UI content controller.
5050
contents:
51-
- playwright.controller.NavPanel
5251
- playwright.controller.NavsetBar
5352
- playwright.controller.NavsetCardPill
5453
- playwright.controller.NavsetCardTab
@@ -58,6 +57,7 @@ quartodoc:
5857
- playwright.controller.NavsetPillList
5958
- playwright.controller.NavsetTab
6059
- playwright.controller.NavsetUnderline
60+
- playwright.controller.NavPanel
6161
- title: Upload and download
6262
desc: Methods for interacting with Shiny app uploading and downloading controller.
6363
contents:

shiny/express/ui/_cm_components.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -927,6 +927,7 @@ def navset_card_pill(
927927
sidebar: Optional[ui.Sidebar] = None,
928928
header: TagChild = None,
929929
footer: TagChild = None,
930+
placement: Literal["above", "below"] = "above",
930931
) -> RecallContextManager[NavSetCard]:
931932
"""
932933
Context manager for a set of nav items as a tabset inside a card container.
@@ -947,6 +948,8 @@ def navset_card_pill(
947948
UI to display above the selected content.
948949
footer
949950
UI to display below the selected content.
951+
placement
952+
Placement of the nav items relative to the content.
950953
"""
951954
return RecallContextManager(
952955
ui.navset_card_pill,
@@ -957,6 +960,7 @@ def navset_card_pill(
957960
sidebar=sidebar,
958961
header=header,
959962
footer=footer,
963+
placement=placement,
960964
),
961965
)
962966

0 commit comments

Comments
 (0)