Skip to content

Commit 6679cb9

Browse files
authored
bug(CI): Quote TEST_FILE usage to avoid args leaking (#1445)
1 parent a6a83fe commit 6679cb9

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

Makefile

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ install-rsconnect: FORCE
159159
pip install git+https://github.com/rstudio/rsconnect-python.git#egg=rsconnect-python
160160

161161
# Full test path to playwright tests
162-
TEST_FILE:=tests/playwright/$(SUB_FILE)
162+
TEST_FILE:="tests/playwright/$(SUB_FILE)"
163163
# All end-to-end tests with playwright
164164
playwright: install-playwright ## All end-to-end tests with playwright; (TEST_FILE="" from root of repo)
165165
pytest $(TEST_FILE) $(PYTEST_BROWSERS)
@@ -172,15 +172,15 @@ playwright-show-trace: ## Show trace of failed tests
172172

173173
# end-to-end tests with playwright; (SUB_FILE="" within tests/playwright/shiny/)
174174
playwright-shiny: FORCE
175-
$(MAKE) playwright TEST_FILE=tests/playwright/shiny/$(SUB_FILE)
175+
$(MAKE) playwright TEST_FILE="tests/playwright/shiny/$(SUB_FILE)"
176176

177177
# end-to-end tests on deployed apps with playwright; (SUB_FILE="" within tests/playwright/deploys/)
178178
playwright-deploys: install-rsconnect
179-
$(MAKE) playwright TEST_FILE=tests/playwright/deploys/$(SUB_FILE) PYTEST_BROWSERS="$(PYTEST_DEPLOYS_BROWSERS)"
179+
$(MAKE) playwright TEST_FILE="tests/playwright/deploys/$(SUB_FILE)" PYTEST_BROWSERS="$(PYTEST_DEPLOYS_BROWSERS)"
180180

181181
# end-to-end tests on all py-shiny examples with playwright; (SUB_FILE="" within tests/playwright/examples/)
182182
playwright-examples: FORCE
183-
$(MAKE) playwright TEST_FILE=tests/playwright/examples/$(SUB_FILE)
183+
$(MAKE) playwright TEST_FILE="tests/playwright/examples/$(SUB_FILE)"
184184

185185
# end-to-end tests with playwright and generate junit report
186186
testrail-junit: install-playwright install-trcli

0 commit comments

Comments
 (0)