chore: adjust parameters for search_content()

[toph-allen]

Intent

Adjust parameters in search_content()

• Expose page_size (query param) and limit (page_offset() arg) in search_content() args following pattern elsewhere in connectapi.
• Do not expose page_number; note the behavior in ... documentation.
• Pass down ... and ensure it gets added to the query string.

Fixes #450

Approach

• Moved parameters around.
• Adjusted tests; added a test for an arbitrarily named other param.

Checklist

• Does this change update NEWS.md (referencing the connected issue if necessary)?
• Does this change need documentation? Have you run devtools::document()?

[jonkeane]

Nice comment explaining why we're testing this thing and that it's not that we believe that page_number is useful, just that it's something that will be passed down.

An alternative (that honestly might not be better! I'm meh about it) would be to use a random extra named argument here. Since we're just asserting expect_GET we just need to confirm the argument is dutifully passed down. But it would require a similar note "We are calling this with not_a_param which isn't a query parameter in the real API to ensure that we are passing unknown args through ... to the query itself.

[toph-allen]

We already have such a test on line 525! :)

I guess… I put this separate test in because page_number is a named param in the inner function, rather than something that just gets incidentally passed down in via ....

I'll remove this test. I don't think the other test needs a similar note because the test name makes it clear what it's doing.

  test_that("content search passes arbitrary parameters through ... to query string", {
    without_internet(
      expect_GET(
        search_content(
          client,
          q = "bream",
          future_param = "value"
        ),
        "https://connect.example/__api__/v1/search/content?q=bream&page_number=1&page_size=500&include=owner%2Cvanity_url&future_param=value" #nolint
      )
    )
  })

(Lmk if I misunderstood what you're saying!)

[karawoo]

took us all a minute to get on the same page, but I feel good about this.