Skip to content

Conversation

@GuidoZam
Copy link
Contributor

Q A
Bug fix? [x]
New feature? [ ]
New sample? [ ]
Related issues? fixes #1719

What's in this Pull Request?

Added iconify/react package as a dependency and not as a devDependency to avoid errors while running gulp bundle.

@joelfmrodrigues joelfmrodrigues merged commit 1c50fa8 into pnp:dev Dec 21, 2023
@joelfmrodrigues
Copy link
Collaborator

Many thanks @GuidoZam !

@GuidoZam GuidoZam deleted the fix-iconify-react-dependency branch December 21, 2023 16:31
@joelfmrodrigues joelfmrodrigues added this to the 3.17.0 milestone Dec 21, 2023
michaelmaillot added a commit that referenced this pull request Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants