Skip to content

Commit 61f4795

Browse files
author
Jon M. Mease
committed
Fix param name error in batch_update()/batch_animate()
1 parent 11dc3cc commit 61f4795

File tree

4 files changed

+18
-14
lines changed

4 files changed

+18
-14
lines changed

plotly/basedatatypes.py

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1658,8 +1658,8 @@ def plotly_update(self,
16581658
# Send a plotly_update message to the frontend (if any)
16591659
if restyle_changes or relayout_changes:
16601660
self._send_update_msg(
1661-
style=restyle_changes,
1662-
layout=relayout_changes,
1661+
restyle_data=restyle_changes,
1662+
relayout_data=relayout_changes,
16631663
trace_indexes=trace_indexes,
16641664
**msg_kwargs)
16651665

@@ -1725,13 +1725,17 @@ def _send_relayout_msg(self, layout, source_view_id=None):
17251725
pass
17261726

17271727
def _send_update_msg(self,
1728-
style,
1729-
layout,
1728+
restyle_data,
1729+
relayout_data,
17301730
trace_indexes=None,
17311731
source_view_id=None):
17321732
pass
17331733

1734-
def _send_animate_msg(self, styles, layout, trace_indexes, animation_opts):
1734+
def _send_animate_msg(self,
1735+
styles_data,
1736+
relayout_data,
1737+
trace_indexes,
1738+
animation_opts):
17351739
pass
17361740

17371741
# Context managers
@@ -1986,8 +1990,8 @@ def _perform_batch_animate(self, animation_opts):
19861990
# --------------------
19871991
# Sends animate message to the front end (if any)
19881992
self._send_animate_msg(
1989-
styles=list(animate_styles),
1990-
layout=animate_layout,
1993+
styles_data=list(animate_styles),
1994+
relayout_data=animate_layout,
19911995
trace_indexes=list(animate_trace_indexes),
19921996
animation_opts=animation_opts)
19931997

plotly/tests/test_core/test_figure_messages/test_batch_animate.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,8 @@ def test_batch_animate(self):
4747

4848
# Check that update message was sent
4949
self.figure._send_animate_msg.assert_called_once_with(
50-
styles=[{'marker.color': 'yellow'}, {'marker.opacity': 0.9}],
51-
layout={'xaxis.range': [10, 20]},
50+
styles_data=[{'marker.color': 'yellow'}, {'marker.opacity': 0.9}],
51+
relayout_data={'xaxis.range': [10, 20]},
5252
trace_indexes=[0, 1],
5353
animation_opts={'transition': {'easing': 'elastic',
5454
'duration': 1200},

plotly/tests/test_core/test_figure_messages/test_plotly_update.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,9 +50,9 @@ def test_batch_update(self):
5050

5151
# Check that update message was sent
5252
self.figure._send_update_msg.assert_called_once_with(
53-
style={'marker.color': ['yellow', Undefined],
53+
restyle_data={'marker.color': ['yellow', Undefined],
5454
'marker.opacity': [Undefined, 0.9]},
55-
layout={'xaxis.range': [10, 20]},
55+
relayout_data={'xaxis.range': [10, 20]},
5656
trace_indexes=[0, 1])
5757

5858
def test_plotly_update(self):
@@ -70,7 +70,7 @@ def test_plotly_update(self):
7070

7171
# Check that update message was sent
7272
self.figure._send_update_msg.assert_called_once_with(
73-
style={'marker.color': ['yellow', Undefined],
73+
restyle_data={'marker.color': ['yellow', Undefined],
7474
'marker.opacity': [Undefined, 0.9]},
75-
layout={'xaxis.range': [10, 20]},
75+
relayout_data={'xaxis.range': [10, 20]},
7676
trace_indexes=[0, 1])

plotly/tests/test_core/test_graph_objs/test_figure_properties.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ def test_update_frames(self):
138138
[{'layout': {'yaxis': {'title': 'f4'}}}]})
139139
self.assertEqual(self.figure.frames[0].layout.yaxis.title, 'f4')
140140

141-
@raises(AttributeError)
141+
@raises(ValueError)
142142
def test_update_invalid_attr(self):
143143
self.figure.layout.update({'xaxis': {'bogus': 32}})
144144

0 commit comments

Comments
 (0)