Skip to content

Try out visibility:inherit default for text #990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 12, 2016
Merged

Try out visibility:inherit default for text #990

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33b8907
Try out visibility:inherit default for text
rreusser Sep 29, 2016
f9cc14c
snapshot: force *visibility: visible* for text elements ...
etpinard Oct 12, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/svg_text_utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ exports.convertToTspans = function(_context, _callback) {
}
_context.text('')
.style({
visibility: 'visible',
visibility: 'inherit',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is definitively the first step to take. 👍

My only concern here is possible incompatibilities in Illustrator and svg conversion tools (e.g. Batik).

To avoid any rolling 🎲 , I'm thinking about adding a few lines to the toSVG routine making sure all exported images get visibility: 'visible' as opposed to inherit while interactive graphs would get 'inherit'.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know about. That's the sort of obscure possibility for interaction that I thought maybe could exist.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to pull this fix wherever you need or redo it elsewhere. I won't worry further about it.

'white-space': 'pre'
});

Expand Down