From 291abb94bca1eb81e6dd665cc0d8cb3b955d0d86 Mon Sep 17 00:00:00 2001 From: archmoj Date: Thu, 25 Nov 2021 16:44:24 -0500 Subject: [PATCH 1/2] avoid bar to jump when selected+text - issue 6041 --- src/components/drawing/index.js | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/components/drawing/index.js b/src/components/drawing/index.js index 6e8fa3fff33..6acdfac46a3 100644 --- a/src/components/drawing/index.js +++ b/src/components/drawing/index.js @@ -927,7 +927,7 @@ var TEXTOFFSETSIGN = { start: 1, end: -1, middle: 0, bottom: 1, top: -1 }; -function textPointPosition(s, textPosition, fontSize, markerRadius) { +function textPointPosition(s, textPosition, fontSize, markerRadius, dontTouchParent) { var group = d3.select(s.node().parentNode); var v = textPosition.indexOf('top') !== -1 ? @@ -949,7 +949,9 @@ function textPointPosition(s, textPosition, fontSize, markerRadius) { // fix the overall text group position s.attr('text-anchor', h); - group.attr('transform', strTranslate(dx, dy)); + if(!dontTouchParent) { + group.attr('transform', strTranslate(dx, dy)); + } } function extracTextFontSize(d, trace) { @@ -1019,7 +1021,8 @@ drawing.selectedTextStyle = function(s, trace) { var fontSize = extracTextFontSize(d, trace); Color.fill(tx, tc); - textPointPosition(tx, tp, fontSize, d.mrc2 || d.mrc); + var dontTouchParent = Registry.traceIs(trace, 'bar-like'); + textPointPosition(tx, tp, fontSize, d.mrc2 || d.mrc, dontTouchParent); }); }; From b51fc718fcba854d180abc831b15efc696482f6f Mon Sep 17 00:00:00 2001 From: archmoj Date: Thu, 25 Nov 2021 17:01:42 -0500 Subject: [PATCH 2/2] log for PR 6043 --- draftlogs/6043_fix.md | 1 + 1 file changed, 1 insertion(+) create mode 100644 draftlogs/6043_fix.md diff --git a/draftlogs/6043_fix.md b/draftlogs/6043_fix.md new file mode 100644 index 00000000000..ce47adc3fc0 --- /dev/null +++ b/draftlogs/6043_fix.md @@ -0,0 +1 @@ + - Avoid bar with text to jump when selected [[#6043](https://github.com/plotly/plotly.js/pull/6043)]