From e0195107d79750ee82419a7fea1691e485e1e5a6 Mon Sep 17 00:00:00 2001 From: etpinard Date: Tue, 1 Dec 2015 14:19:43 -0500 Subject: [PATCH 1/2] fix display mode bar logic --- src/components/modebar/manage.js | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/components/modebar/manage.js b/src/components/modebar/manage.js index 2a64c5efd53..24bef9578dc 100644 --- a/src/components/modebar/manage.js +++ b/src/components/modebar/manage.js @@ -27,9 +27,11 @@ module.exports = function manageModeBar(gd) { context = gd._context, modeBar = fullLayout._modeBar; - if(!context.displayModeBar && modeBar) { - modeBar.destroy(); - delete fullLayout._modeBar; + if(!context.displayModeBar) { + if(modeBar) { + modeBar.destroy(); + delete fullLayout._modeBar; + } return; } From ae642bef479a35d90364ecece331b356d9ee26b6 Mon Sep 17 00:00:00 2001 From: etpinard Date: Tue, 1 Dec 2015 14:26:32 -0500 Subject: [PATCH 2/2] add test for displayModeBar setup --- test/jasmine/tests/modebar_test.js | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/test/jasmine/tests/modebar_test.js b/test/jasmine/tests/modebar_test.js index 86d65b3780c..942663fbf9e 100644 --- a/test/jasmine/tests/modebar_test.js +++ b/test/jasmine/tests/modebar_test.js @@ -290,6 +290,14 @@ describe('ModeBar', function() { }); it('displays or not mode bar according to displayModeBar config arg', function() { + var gd = getMockGraphInfo(); + gd._context.displayModeBar = false; + + manageModeBar(gd); + expect(gd._fullLayout._modeBar).not.toBeDefined(); + }); + + it('updates mode bar according to displayModeBar config arg', function() { var gd = getMockGraphInfo(); manageModeBar(gd); expect(gd._fullLayout._modeBar).toBeDefined();