From 05a74d980959336f0c5a958f3b41bf6a7b1eb67e Mon Sep 17 00:00:00 2001 From: archmoj Date: Fri, 14 May 2021 09:29:15 -0400 Subject: [PATCH 1/3] deprecate transform attributes --- src/components/calendars/index.js | 1 + src/plots/attributes.js | 1 + 2 files changed, 2 insertions(+) diff --git a/src/components/calendars/index.js b/src/components/calendars/index.js index 5ff2791ac49..0c4551dbf5b 100644 --- a/src/components/calendars/index.js +++ b/src/components/calendars/index.js @@ -234,6 +234,7 @@ module.exports = { } }, transforms: { + description: 'This attribute is deprecated and it may be removed from the API in next major version.', filter: { valuecalendar: makeAttrs([ 'Sets the calendar system to use for `value`, if it is a date.' diff --git a/src/plots/attributes.js b/src/plots/attributes.js index 20ff1c2a3b3..7a799e1dde7 100644 --- a/src/plots/attributes.js +++ b/src/plots/attributes.js @@ -167,6 +167,7 @@ module.exports = { _isLinkedToArray: 'transform', editType: 'calc', description: [ + 'This attribute is deprecated and it may be removed from the API in next major version.', 'An array of operations that manipulate the trace data,', 'for example filtering or sorting the data arrays.' ].join(' ') From d36e6508e01ee0a97722f12e9ae9acde60489d2e Mon Sep 17 00:00:00 2001 From: Mojtaba Samimi <33888540+archmoj@users.noreply.github.com> Date: Fri, 14 May 2021 10:11:14 -0400 Subject: [PATCH 2/3] add warning for deprecated transforms Co-authored-by: Alex Johnson --- src/plots/attributes.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/plots/attributes.js b/src/plots/attributes.js index 7a799e1dde7..246b80f06a1 100644 --- a/src/plots/attributes.js +++ b/src/plots/attributes.js @@ -167,7 +167,7 @@ module.exports = { _isLinkedToArray: 'transform', editType: 'calc', description: [ - 'This attribute is deprecated and it may be removed from the API in next major version.', + 'WARNING: All transforms are deprecated and may be removed from the API in next major version.', 'An array of operations that manipulate the trace data,', 'for example filtering or sorting the data arrays.' ].join(' ') From 31073ab006833961273a98dc01a46418c0d049a8 Mon Sep 17 00:00:00 2001 From: archmoj Date: Fri, 14 May 2021 10:24:14 -0400 Subject: [PATCH 3/3] place deprecated warnings in calendars transform descriptions --- src/components/calendars/index.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/components/calendars/index.js b/src/components/calendars/index.js index 0c4551dbf5b..293f9e4444a 100644 --- a/src/components/calendars/index.js +++ b/src/components/calendars/index.js @@ -234,12 +234,13 @@ module.exports = { } }, transforms: { - description: 'This attribute is deprecated and it may be removed from the API in next major version.', filter: { valuecalendar: makeAttrs([ + 'WARNING: All transforms are deprecated and may be removed from the API in next major version.', 'Sets the calendar system to use for `value`, if it is a date.' ].join(' ')), targetcalendar: makeAttrs([ + 'WARNING: All transforms are deprecated and may be removed from the API in next major version.', 'Sets the calendar system to use for `target`, if it is an', 'array of dates. If `target` is a string (eg *x*) we use the', 'corresponding trace attribute (eg `xcalendar`) if it exists,',