From 494c52aec5e3c345300b3d7111f76bc2a0663137 Mon Sep 17 00:00:00 2001 From: Florian Maak Date: Tue, 29 Oct 2019 19:32:39 +0100 Subject: [PATCH 1/2] append coverSlip to fullscreen element instead of body --- src/components/dragelement/index.js | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/components/dragelement/index.js b/src/components/dragelement/index.js index ceac36906ea..3e194e41a75 100644 --- a/src/components/dragelement/index.js +++ b/src/components/dragelement/index.js @@ -264,6 +264,7 @@ dragElement.init = function init(options) { function coverSlip() { var cover = document.createElement('div'); + var fullscreenElement = document.fullscreenElement; cover.className = 'dragcover'; var cStyle = cover.style; @@ -275,6 +276,12 @@ function coverSlip() { cStyle.zIndex = 999999999; cStyle.background = 'none'; + if(fullscreenElement) { + fullscreenElement.appendChild(cover); + + return cover; + } + document.body.appendChild(cover); return cover; From 05d944e2d1abfd71d71ccc4a9e1f273ca6262f91 Mon Sep 17 00:00:00 2001 From: Florian Maak Date: Wed, 30 Oct 2019 07:53:00 +0100 Subject: [PATCH 2/2] added fscreen to handle fullscreen --- package-lock.json | 5 +++++ package.json | 1 + src/components/dragelement/index.js | 3 ++- 3 files changed, 8 insertions(+), 1 deletion(-) diff --git a/package-lock.json b/package-lock.json index 0ffe75cfe9a..1784b01651c 100644 --- a/package-lock.json +++ b/package-lock.json @@ -4295,6 +4295,11 @@ "resolved": "https://registry.npmjs.org/fs.realpath/-/fs.realpath-1.0.0.tgz", "integrity": "sha1-FQStJSMVjKpA20onh8sBQRmU6k8=" }, + "fscreen": { + "version": "1.0.2", + "resolved": "https://registry.npmjs.org/fscreen/-/fscreen-1.0.2.tgz", + "integrity": "sha1-xMUdltgZ11oZ1yjg30Rfm+m7mE8=" + }, "fsevents": { "version": "2.0.7", "resolved": "https://registry.npmjs.org/fsevents/-/fsevents-2.0.7.tgz", diff --git a/package.json b/package.json index 47029f41274..81c8a95824e 100644 --- a/package.json +++ b/package.json @@ -73,6 +73,7 @@ "delaunay-triangulate": "^1.1.6", "es6-promise": "^3.0.2", "fast-isnumeric": "^1.1.3", + "fscreen": "^1.0.2", "gl-cone3d": "^1.5.1", "gl-contour2d": "^1.1.6", "gl-error3d": "^1.0.15", diff --git a/src/components/dragelement/index.js b/src/components/dragelement/index.js index 3e194e41a75..57f53bf0474 100644 --- a/src/components/dragelement/index.js +++ b/src/components/dragelement/index.js @@ -11,6 +11,7 @@ var mouseOffset = require('mouse-event-offset'); var hasHover = require('has-hover'); var supportsPassive = require('has-passive-events'); +var fscreen = require('fscreen').default; var removeElement = require('../../lib').removeElement; var constants = require('../../plots/cartesian/constants'); @@ -264,7 +265,7 @@ dragElement.init = function init(options) { function coverSlip() { var cover = document.createElement('div'); - var fullscreenElement = document.fullscreenElement; + var fullscreenElement = fscreen.fullscreenElement; cover.className = 'dragcover'; var cStyle = cover.style;