From 581b6d673af7bca3a4102bc9dba929381efac471 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=89tienne=20T=C3=A9treault-Pinard?= Date: Tue, 8 Mar 2016 10:37:57 -0500 Subject: [PATCH 1/2] list two already enforced rules: - no-whitespace-before-property - operator-linebreak --- .eslintrc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.eslintrc b/.eslintrc index 8279363a134..600bda9ce9e 100644 --- a/.eslintrc +++ b/.eslintrc @@ -32,9 +32,12 @@ "space-before-function-paren": [2, "never"], "space-before-blocks": [2], "no-multi-spaces": [2], + "no-whitespace-before-property": [2], + "no-unexpected-multiline": [2], "space-infix-ops": [0, {"int32Hint": false}], "quotes": [2, "single"], "dot-notation": [2, {"allowKeywords": false}], + "operator-linebreak": [2, "after"], "eqeqeq": [2], "new-cap": [0], "no-redeclare": [2, {"builtinGlobals": true}], @@ -44,7 +47,6 @@ "no-use-before-define": [2, "nofunc"], "no-loop-func": [2], "no-console": [0], - "no-unexpected-multiline": [2], "no-unused-labels": [2] }, } From b1c2b15c1c340c4d9ec4d6f7b67a62dc4fb7a0b7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=89tienne=20T=C3=A9treault-Pinard?= Date: Tue, 8 Mar 2016 10:39:54 -0500 Subject: [PATCH 2/2] enforce eol-last rule (all file must end with \n) --- .eslintrc | 1 + test/jasmine/tests/hover_label_test.js | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.eslintrc b/.eslintrc index 600bda9ce9e..384ef0783ce 100644 --- a/.eslintrc +++ b/.eslintrc @@ -9,6 +9,7 @@ "rules": { "no-trailing-spaces": [2], "no-multiple-empty-lines": [2, {"max": 2, "maxEOF": 1}], + "eol-last": [2], "linebreak-style": [2, "unix"], "indent": [2, 4, {"SwitchCase": 1}], "max-len": [0, 80], diff --git a/test/jasmine/tests/hover_label_test.js b/test/jasmine/tests/hover_label_test.js index f5068a5e9ba..37e3c7b27b6 100644 --- a/test/jasmine/tests/hover_label_test.js +++ b/test/jasmine/tests/hover_label_test.js @@ -430,4 +430,4 @@ describe('hover info on stacked subplots', function() { expect(textNodes[2][1].innerHTML).toEqual('3'); }); }); -}); \ No newline at end of file +});