Fix pretest task for require.js test fixture #1036
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
masteris currently broken, but rest assured, there's nothing wrong withv1.18.0itself (yet).In brief,
The
npm run pretestbuilds a fixture to testplotly.min.jsin a Require.js environment in this suite.To do so, in
master,pretest.jsuses a string replace to place the bundle code in a Require.js define statement. This string replace currently breaks the fixture and thus making the Require.js test fail.In this PR, the Require.js test fixture is built using a more robust arrary
join('').